Skip to content

Commit

Permalink
feat: Change LogMojo instance variables' access modifier to protected
Browse files Browse the repository at this point in the history
Signed-off-by: Raydhitya Yoseph <raydhitya.yoseph@gmail.com>
  • Loading branch information
yraydhitya authored and manusa committed Oct 7, 2021
1 parent f40f25c commit c362232
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Usage:
* Fix #923: QuakusGenerator not applicable when using `io.quarkus.platform` groupId
* Fix #895: FileUtil#createDirectory works for files with trailing separator (`/`)
* Fix #913: Make provider name configurable
* Fix #877: LogMojo: Change access modifiers to protected for use in XML configuration

### 1.4.0 (2021-07-27)
* Fix #253: Refactor JKubeServiceHub's BuildService election mechanism via ServiceLoader
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ If your pod has multiple containers you can configure the container name to log
mvn {goal-prefix}:log -Djkube.log.container=foo
----

.Example XML configuration for log goal
[source,xml,indent=0,subs="verbatim,quotes,attributes"]
<plugin>
<configuration>
<logFollow>true</logFollow>
<logContainer>container</logContainer>
<logPod>pod</logPod>
</configuration>
</plugin>

[[Supported-Properties-Log]]
=== Supported Properties for Log goal

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
public class LogMojo extends ApplyMojo {

@Parameter(property = "jkube.log.follow", defaultValue = "true")
private boolean logFollow;
protected boolean logFollow;
@Parameter(property = "jkube.log.container")
private String logContainerName;
protected String logContainerName;
@Parameter(property = "jkube.log.pod")
private String logPodName;
protected String logPodName;

@Override
protected void applyEntities(final KubernetesClient kubernetes, String fileName, final Collection<HasMetadata> entities) {
Expand Down

0 comments on commit c362232

Please sign in to comment.