Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate yaml files for different environments #1218

Closed
borramTAS opened this issue Jan 16, 2022 · 5 comments · Fixed by #1484
Closed

Generate yaml files for different environments #1218

borramTAS opened this issue Jan 16, 2022 · 5 comments · Fixed by #1484
Assignees
@rohanKanojia
Labels
demoable Issues which can be demoed during the Sprint review meeting enhancement New feature or request
Milestone
1.8.0

Comments

@borramTAS
Copy link

Description

I need to generate different yaml files for different environments, not only for the same environment but also different configurations for the same environment. It would be useful to have a basic templating system to be used for the different targets and specific modifications for the different combinations, it could use a system based on directories, one commons and one for each target (environment or deployment) for example.

Related to
@manusa
Copy link
Member

manusa commented Jan 17, 2022

If I understand correctly, this issue is requesting the possibility to apply more than one environment configuration.

Considering the following directory structure

src/main/jkube/dev
src/main/jkube/prod
src/main/jkube/common

Being able to provide <jkube.environment>common,dev</jkube.environment> or <jkube.environment>common,prod</jkube.environment> as a valid configuration that would account for fragments in the listed directories would solve your issue.

@manusa manusa added the enhancement New feature or request label Jan 17, 2022
@borramTAS
Copy link
Author

If I understand correctly, this issue is requesting the possibility to apply more than one environment configuration.

Basically yes.

Being able to provide <jkube.environment>common,dev</jkube.environment> or <jkube.environment>common,prod</jkube.environment> as a valid configuration that would account for fragments in the listed directories would solve your issue.

I would say yes, it would solve my issue.

@manusa manusa added this to the 1.x milestone Feb 23, 2022
@rohanKanojia rohanKanojia self-assigned this Apr 25, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 26, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
0ad41fe 
…ipse-jkube#1218

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 27, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
67b1c9c 
…ipse-jkube#1218

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 27, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
502a15a 
…ipse-jkube#1218

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 2, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
53a4429 
…ipse-jkube#1218

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 2, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
a5cfb11 
…ipse-jkube#1218)

Modify ResourceServiceConfig to recieve a list of files as resourceDirs
instead of receiving a single resourceDir. Resource fragments in these
files can be combined while generating resources.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 2, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
8ad562f 
…ipse-jkube#1218)

Modify ResourceServiceConfig to recieve a list of files as resourceDirs
instead of receiving a single resourceDir. Resource fragments in these
files can be combined while generating resources.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 4, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
b933ba2 
…ipse-jkube#1218)

Modify ResourceServiceConfig to recieve a list of files as resourceDirs
instead of receiving a single resourceDir. Resource fragments in these
files can be combined while generating resources.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue May 4, 2022
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 4, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
9ef2ad2 
…ipse-jkube#1218)

Modify ResourceServiceConfig to recieve a list of files as resourceDirs
instead of receiving a single resourceDir. Resource fragments in these
files can be combined while generating resources.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 4, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
84a9786 
…ipse-jkube#1218)

Modify ResourceServiceConfig to recieve a list of files as resourceDirs
instead of receiving a single resourceDir. Resource fragments in these
files can be combined while generating resources.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 4, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
c35f569 
…ipse-jkube#1218)

Modify ResourceServiceConfig to recieve a list of files as resourceDirs
instead of receiving a single resourceDir. Resource fragments in these
files can be combined while generating resources.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 4, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
242498e 
…ipse-jkube#1218)

Modify ResourceServiceConfig to recieve a list of files as resourceDirs
instead of receiving a single resourceDir. Resource fragments in these
files can be combined while generating resources.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 4, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
213d59c 
…ipse-jkube#1218)

Modify ResourceServiceConfig to recieve a list of files as resourceDirs
instead of receiving a single resourceDir. Resource fragments in these
files can be combined while generating resources.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa modified the milestones: 1.x, 1.8.0 May 23, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 23, 2022
@rohanKanojia
fix (jkube-kit) : Generate yaml files for different environments (ecl…
0b5d3e3 
…ipse-jkube#1218)

Modify ResourceServiceConfig to recieve a list of files as resourceDirs
instead of receiving a single resourceDir. Resource fragments in these
files can be combined while generating resources.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue May 24, 2022
@rohanKanojia @manusa
fix (jkube-kit) : Generate yaml files for different environments (#1218)
8a0b216 
Modify ResourceServiceConfig to recieve a list of files as resourceDirs
instead of receiving a single resourceDir. Resource fragments in these
files can be combined while generating resources.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@borramTAS
Copy link
Author

Very good news, I will test it as soon as it is available, thank you very much!

@borramTAS
Copy link
Author

I refactored my project and now it works like a charm, I'll try a more complex scenario.

@manusa
Copy link
Member

manusa commented May 24, 2022

I refactored my project and now it works like a charm, I'll try a more complex scenario.

Great news, thanks for the feedback!

@manusa manusa added the demoable Issues which can be demoed during the Sprint review meeting label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
demoable Issues which can be demoed during the Sprint review meeting enhancement New feature or request
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

fix (jkube-kit) : Generate yaml files for different environments (#1218) rohanKanojia/jkube
3 participants
@manusa @rohanKanojia @borramTAS