Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectLabelEnricher: group and version labels should be configurable #1268

Closed
manusa opened this issue Feb 4, 2022 · 0 comments · Fixed by #1461
Closed

ProjectLabelEnricher: group and version labels should be configurable #1268

manusa opened this issue Feb 4, 2022 · 0 comments · Fixed by #1461
Assignees
@rohanKanojia
Labels
demoable Issues which can be demoed during the Sprint review meeting enhancement New feature or request
Milestone
1.8.0

Comments

@manusa
Copy link
Member

manusa commented Feb 4, 2022 •
edited

Description

ProjectLabelEnricher should allow the override of the group and version labels too.

Both fields are inferred from the Maven/Gradle project configuration, which might generate invalid label values (as reported per some users). Since these labels are commonly used in most resources to group them by application, having them fully customizable would be interesting.

Related to #913 / #930
@manusa manusa added this to the 1.7.0 milestone Feb 4, 2022
@manusa manusa added the enhancement New feature or request label Feb 4, 2022
@manusa manusa modified the milestones: 1.7.0, 1.x Feb 23, 2022
@sunix sunix added the demoable Issues which can be demoed during the Sprint review meeting label Apr 11, 2022
@rohanKanojia rohanKanojia self-assigned this Apr 19, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 19, 2022
@rohanKanojia
fix (jkube-kit) : ProjectLabelEnricher group and version labels shoul…
4d47fbf 
…d be configurable (eclipse-jkube#1268)

Add two new options to ProjectLabelEnricher configuration for allowing
user to customize `group` and `version` labels added to match selectors
by ProjectLabelEnricher

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 20, 2022
@rohanKanojia
fix (jkube-kit) : ProjectLabelEnricher group and version labels shoul…
033a410 
…d be configurable (eclipse-jkube#1268)

Add two new options to ProjectLabelEnricher configuration for allowing
user to customize `group` and `version` labels added to match selectors
by ProjectLabelEnricher

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Apr 20, 2022
Merged
12 tasks
@manusa manusa modified the milestones: 1.x, 1.8.0 Apr 21, 2022
manusa pushed a commit that referenced this issue Apr 21, 2022
@rohanKanojia @manusa
fix (jkube-kit) : ProjectLabelEnricher group and version labels shoul…
4dfae9e 
…d be configurable (#1268)

Add two new options to ProjectLabelEnricher configuration for allowing
user to customize `group` and `version` labels added to match selectors
by ProjectLabelEnricher

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
demoable Issues which can be demoed during the Sprint review meeting enhancement New feature or request
Projects
None yet
Milestone
1.8.0
3 participants
@manusa @sunix @rohanKanojia