Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle-Enricher: TriggersAnnotationEnricher #1301

Closed
3 tasks done
manusa opened this issue Feb 21, 2022 · 0 comments · Fixed by #1360
Closed
3 tasks done

Gradle-Enricher: TriggersAnnotationEnricher #1301

manusa opened this issue Feb 21, 2022 · 0 comments · Fixed by #1360
Assignees
@rohanKanojia
Labels
component/gradle-plugin Related to the Gradle Plugins
Milestone
1.8.0

Comments

@manusa
Copy link
Member

manusa commented Feb 21, 2022 •
edited
Loading

Description

Child of #31

TriggersAnnotationEnricher works with Gradle

AC

  • Enricher documentation is ported to Gradle
    Improve the documentation (maybe add a reference to the OpenShift specific documentation)
  • Create IT to verify that the annotation is added to applicable resources
  • openshift.yml is generated as expected
@manusa manusa added the component/gradle-plugin Related to the Gradle Plugins label Feb 21, 2022
@manusa manusa mentioned this issue Feb 21, 2022
Open
16 tasks
@rohanKanojia rohanKanojia self-assigned this Mar 17, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Mar 17, 2022
@rohanKanojia
test (gradle-plugin/it) : Add gradle integration test for TriggersAnn…
6507c63 
…otationIT (eclipse-jkube#1301)

Add Gradle integration test to verify `image.openshift.io/triggers`
annotation gets added to kubernetes resources with respective triggers.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Mar 17, 2022
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Mar 21, 2022
@rohanKanojia
test (gradle-plugin/it) : Add gradle integration test for TriggersAnn…
e8e9449 
…otationIT (eclipse-jkube#1301)

Add Gradle integration test to verify `image.openshift.io/triggers`
annotation gets added to kubernetes resources with respective triggers.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Mar 22, 2022
@rohanKanojia
test (gradle-plugin/it) : Add gradle integration test for TriggersAnn…
08494bf 
…otationIT (eclipse-jkube#1301)

Add Gradle integration test to verify `image.openshift.io/triggers`
annotation gets added to kubernetes resources with respective triggers.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to the 1.8.0 milestone Mar 23, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Mar 23, 2022
@rohanKanojia
test (gradle-plugin/it) : Add gradle integration test for TriggersAnn…
5596ba3 
…otationIT (eclipse-jkube#1301)

Add Gradle integration test to verify `image.openshift.io/triggers`
annotation gets added to kubernetes resources with respective triggers.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Mar 23, 2022
@rohanKanojia @manusa
test (gradle-plugin/it) : Add gradle integration test for TriggersAnn…
a714d53 
…otationIT (#1301)

Add Gradle integration test to verify `image.openshift.io/triggers`
annotation gets added to kubernetes resources with respective triggers.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
component/gradle-plugin Related to the Gradle Plugins
Projects
None yet
Milestone
1.8.0
2 participants
@manusa @rohanKanojia