Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Startup Probes via XML/DSL configuration #1322

Closed
2 of 5 tasks
manusa opened this issue Mar 2, 2022 · 1 comment · Fixed by #1466
Closed
2 of 5 tasks

Support for Startup Probes via XML/DSL configuration #1322

manusa opened this issue Mar 2, 2022 · 1 comment · Fixed by #1466
Assignees
@rohanKanojia
Labels
demoable Issues which can be demoed during the Sprint review meeting enhancement New feature or request
Milestone
1.8.0

Comments

@manusa
Copy link
Member

manusa commented Mar 2, 2022 •
edited

Description

Eclipse JKube currently supports the definition and configuration of readiness and liveness probes.

https://github.com/eclipse/jkube/blob/6d4ef1b0b7e622a546f124a3b522abf3425d2efd/jkube-kit/config/resource/src/main/java/org/eclipse/jkube/kit/config/resource/ResourceConfig.java#L50-L51

We should provide an additional configuration option to define startup probes too.

Containers can be generated with or without startup probes (optional)

AC

  • A new field ProbeConfig startup is defined in ResourceConfig
  • ContainerHandler adds the startup probe to the container
  • ITs updated to test both options (with or without startup probe)
  • Documentation updated to add new configuration option (maybe snippet)
  • TBD HealthCheckEnricher implementations add a startup probe too (needs further analysis) - Probably create different issues for each

Additional info
@manusa manusa added the enhancement New feature or request label Mar 2, 2022
@manusa manusa added this to the 1.x milestone Mar 2, 2022
@manusa manusa changed the title Support for Startup Probes Support for Startup Probes via XML/DSL configuration Mar 2, 2022
@sunix sunix added the demoable Issues which can be demoed during the Sprint review meeting label Apr 11, 2022
@rohanKanojia rohanKanojia self-assigned this Apr 20, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 20, 2022
@rohanKanojia
feat (jkube-kit/config) : Support for Startup Probes via XML/DSL conf…
a63c79b 
…iguration (eclipse-jkube#1322)

Add new startup probe field in resource configuration which should be
available in XML maven plugin configuration/ Groovy DSL configuration in
maven and gradle plugins respectively.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 21, 2022
@rohanKanojia
feat (jkube-kit/config) : Support for Startup Probes via XML/DSL conf…
89dc657 
…iguration (eclipse-jkube#1322)

Add new startup probe field in resource configuration which should be
available in XML maven plugin configuration/ Groovy DSL configuration in
maven and gradle plugins respectively.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Apr 21, 2022
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 21, 2022
@rohanKanojia
feat (jkube-kit/config) : Support for Startup Probes via XML/DSL conf…
7761690 
…iguration (eclipse-jkube#1322)

Add new startup probe field in resource configuration which should be
available in XML maven plugin configuration/ Groovy DSL configuration in
maven and gradle plugins respectively.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 22, 2022
@rohanKanojia
feat (jkube-kit/config) : Support for Startup Probes via XML/DSL conf…
0562f31 
…iguration (eclipse-jkube#1322)

Add new startup probe field in resource configuration which should be
available in XML maven plugin configuration/ Groovy DSL configuration in
maven and gradle plugins respectively.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
This was referenced Apr 22, 2022
Closed
Closed
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 22, 2022
@rohanKanojia
feat (jkube-kit/config) : Support for Startup Probes via XML/DSL conf…
f9b08ba 
…iguration (eclipse-jkube#1322)

Add new startup probe field in resource configuration which should be
available in XML maven plugin configuration/ Groovy DSL configuration in
maven and gradle plugins respectively.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Apr 25, 2022
Closed
2 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 25, 2022
@rohanKanojia
feat (jkube-kit/config) : Support for Startup Probes via XML/DSL conf…
99b072d 
…iguration (eclipse-jkube#1322)

Add new startup probe field in resource configuration which should be
available in XML maven plugin configuration/ Groovy DSL configuration in
maven and gradle plugins respectively.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia
Copy link
Member

I've created HealthCheckEnricher implementation related issues for frameworks that seem to support startup probes:

For Vert.x, Micronaut and Thorntail I couldn't find anything for startup probes.

rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 26, 2022
@rohanKanojia
feat (jkube-kit/config) : Support for Startup Probes via XML/DSL conf…
c57068c 
…iguration (eclipse-jkube#1322)

Add new startup probe field in resource configuration which should be
available in XML maven plugin configuration/ Groovy DSL configuration in
maven and gradle plugins respectively.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa modified the milestones: 1.x, 1.8.0 Apr 27, 2022
manusa pushed a commit that referenced this issue Apr 28, 2022
@rohanKanojia @manusa
feat (jkube-kit/config) : Support for Startup Probes via XML/DSL conf…
7c229fe 
…iguration (#1322)

Add new startup probe field in resource configuration which should be
available in XML maven plugin configuration/ Groovy DSL configuration in
maven and gradle plugins respectively.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
demoable Issues which can be demoed during the Sprint review meeting enhancement New feature or request
Projects
None yet
Milestone
1.8.0
3 participants
@manusa @sunix @rohanKanojia