New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional image tags issue #1411
Comments
That's the purpose of these elements (tags,tag). Could you please share a reproducer pom.xml so we can see where the problem is? |
Enough with plugin conf? <plugin>
<groupId>org.eclipse.jkube</groupId>
<artifactId>openshift-maven-plugin</artifactId>
<version>1.7.0</version>
<configuration>
<images>
<image>
<name>${openshiftnamespace}/%a:%v</name>
<build>
<fromExt>
<name>${openshift-base-image}</name>
<namespace>${image-namespace}</namespace>
<kind>ImageStreamTag</kind>
</fromExt>
<env>
<JAVA_APP_DIR>/deployments</JAVA_APP_DIR>
</env>
<tags>
<tag>%v</tag>
<tag>latest</tag>
</tags>
</build>
</image>
</images>
</configuration>
</plugin> |
@Surfjoan : by tags, are you referring to ImageStreamTags ? Looking at code in OpenShiftBuildService I don't think we support creating multiple ImageStreamTags at the moment. But we can refactor this to support your use case. Without the plugin, how do you configure BuildConfig to create multiple ImageStreamTags as build output? Or do you do |
…ultiple tags specified in Image Build Configuration (eclipse-jkube#1411) Add support for adding multiple ImageStreamTags specified in `tags` section of image's `build` configuration. After S2I build new ImageStreamTags as specified in build configuration would get created. They would point to same image as done by orignal ImageStreamTag output of S2I build. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…ultiple tags specified in Image Build Configuration (eclipse-jkube#1411) Add support for adding multiple ImageStreamTags specified in `tags` section of image's `build` configuration. After S2I build new ImageStreamTags as specified in build configuration would get created. They would point to same image as done by orignal ImageStreamTag output of S2I build. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Cool! I am on vacation now but going to test it once i am back
Den ons 29 juni 2022 16:51Rohan Kumar ***@***.***> skrev:
… @Surfjoan <https://github.com/Surfjoan> : I've created a PR #1639
<#1639> that creates ImageStreamTags
based on tags specified in <build><tags> section (similar to what we do
with oc tag ... command) . Does this align with your expectations? Would
be awesome if you could provide some feedback regarding this.
—
Reply to this email directly, view it on GitHub
<#1411 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4HKKJ6WKQK7RUWPDSX6M3VRRPFZANCNFSM5SA6UA2Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…ultiple tags specified in Image Build Configuration (eclipse-jkube#1411) Add support for adding multiple ImageStreamTags specified in `tags` section of image's `build` configuration. After S2I build new ImageStreamTags as specified in build configuration would get created. They would point to same image as done by orignal ImageStreamTag output of S2I build. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…ultiple tags specified in Image Build Configuration (eclipse-jkube#1411) Add support for adding multiple ImageStreamTags specified in `tags` section of image's `build` configuration. After S2I build new ImageStreamTags as specified in build configuration would get created. They would point to same image as done by orignal ImageStreamTag output of S2I build. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…ultiple tags specified in Image Build Configuration (#1411) Add support for adding multiple ImageStreamTags specified in `tags` section of image's `build` configuration. After S2I build new ImageStreamTags as specified in build configuration would get created. They would point to same image as done by orignal ImageStreamTag output of S2I build. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…ultiple tags specified in Image Build Configuration (eclipse-jkube#1411) Add support for adding multiple ImageStreamTags specified in `tags` section of image's `build` configuration. After S2I build new ImageStreamTags as specified in build configuration would get created. They would point to same image as done by orignal ImageStreamTag output of S2I build. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Description
Info
Eclipse JKube version: 1.7.0
Maven version (
mvn -v
): 3.5.4Kubernetes / Red Hat OpenShift setup and version: Openshift v3.11
If it's a bug, how to reproduce:
I have set the name element to this <name>${namespace}/%a:%v</name> but want to add an additional tag on the image in openshift after it is built. So i added the <tags><tag>my-tag</tag></tags> elements to the plugin configuration in pom. According to documentation this is the way to add additional tags to the image after it is being built. But no additional tags are created. Or am i misunderstanding the purpose of the element?
If it's a feature request, what is your use case :
Sample Reproducer Project : [GitHub Clone URL]
The text was updated successfully, but these errors were encountered: