Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HelidonHealthCheckEnricher to add Kubernetes health checks for Helidon applications #1713

Closed
3 of 4 tasks
rohanKanojia opened this issue Aug 19, 2022 · 0 comments · Fixed by #2130
Closed
3 of 4 tasks
Assignees
Milestone

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Aug 19, 2022

Component

JKube Kit

Task description

Description

Child of #1475 #443

Expected Behavior

Helidon Microprofile Health seems to be implementation of Microprofile Health.

Eclipse JKube should generate readiness, liveness and startup probes when io.helidon.microprofile.health:helidon-microprofile-health dependency is present in project

Acceptance Criteria

  • Add HelidonHealthCheckEnricher in jkube-kit-helidon module that would extend AbstractMicroprofileHealthCheckEnricher
  • Add unit tests to verify probes are added as expected
  • Add documentation
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 10, 2023
…ealth checks for Helidon applications (eclipse-jkube#1713)

+ Add HelidonHealthCheckEnricher to automatically add liveness,
  readiness and start probes based on already existing microprofile
  health check enricher

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 10, 2023
…ealth checks for Helidon applications (eclipse-jkube#1713)

+ Add HelidonHealthCheckEnricher to automatically add liveness,
  readiness and start probes based on already existing microprofile
  health check enricher

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia self-assigned this Apr 10, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 11, 2023
…ealth checks for Helidon applications (eclipse-jkube#1713)

+ Add HelidonHealthCheckEnricher to automatically add liveness,
  readiness and start probes based on already existing microprofile
  health check enricher

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 13, 2023
…ealth checks for Helidon applications (eclipse-jkube#1713)

+ Add HelidonHealthCheckEnricher to automatically add liveness,
  readiness and start probes based on already existing microprofile
  health check enricher

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 19, 2023
…ealth checks for Helidon applications (eclipse-jkube#1713)

+ Add HelidonHealthCheckEnricher to automatically add liveness,
  readiness and start probes based on already existing microprofile
  health check enricher

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to the 1.14.0 milestone Jun 20, 2023
manusa pushed a commit that referenced this issue Jun 20, 2023
…ealth checks for Helidon applications (#1713)

+ Add HelidonHealthCheckEnricher to automatically add liveness,
  readiness and start probes based on already existing microprofile
  health check enricher

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants