Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HelidonGenerator to add opinionated container image for Helidon applications #1714

Closed
3 tasks
rohanKanojia opened this issue Aug 19, 2022 · 2 comments · Fixed by #2129
Closed
3 tasks
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

Child of #1475

Just like other frameworks, we need to add opinionated container image creation support for Helidon. For that, we need to add HelidonGenerator in a new module jkube-kit-helidon that would get activated when io.helidon.build-tools:helidon-maven-plugin is present in project.

Expected Behavior

Use should be able to generate container images in zero configuration with Helidon framework

Acceptance Criteria

  • Add HelidonGenerator which would extend JavaExecGenerator
  • Add unit tests to verify HelidonGenerator works as expected
  • Add documentation for this new generator
@manusa manusa added the enhancement New feature or request label Aug 30, 2022
@vaishnavi-ramanujapuram
Copy link

Hi, I would like to contribute to the above issue. I'm a first time contributor and this is mandatory for my course work. I'm willing to learn the concepts related to it while solving it. Could you please assign it to me.

@rohanKanojia
Copy link
Member Author

@vaishnavi-ramanujapuram : I'm afraid this might not be an issue for newcomers. But if you want to try it I won't stop you.

In order to work on this, you'd need to learn about Helidon, Docker, and JKube. You need to add a module similar to https://github.com/eclipse/jkube/tree/master/jkube-kit/jkube-kit-micronaut

rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 4, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia self-assigned this Apr 5, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 5, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 10, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 10, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 10, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 11, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 11, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 13, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 13, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit to rohanKanojia/jkube that referenced this issue Jun 19, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit to rohanKanojia/jkube that referenced this issue Jun 19, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit to rohanKanojia/jkube that referenced this issue Jun 19, 2023
…ntainer images for Helidon projects (eclipse-jkube#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to the 1.14.0 milestone Jun 19, 2023
manusa pushed a commit that referenced this issue Jun 19, 2023
…ntainer images for Helidon projects (#1714)

+ Add jkube-kit-helidon module which contains generator for creating
  opinionated ImageConfiguration for Helidon

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants