Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenShift compliant git/vcs annotations #173

Closed
manusa opened this issue May 4, 2020 · 0 comments · Fixed by #212
Closed

Use OpenShift compliant git/vcs annotations #173

manusa opened this issue May 4, 2020 · 0 comments · Fixed by #212
Assignees
Projects
Milestone

Comments

@manusa
Copy link
Member

manusa commented May 4, 2020

Description

As of now, Elipse JKube adds the following annotations to every generated resource manifest jkube.io/git-branch, jkube.io/git-url, jkube.io/git-commit.

We should include or replace the ones recommended in @gorkem app-label guidelines(app.openshift.io/vcs-uri, app.openshift.io/vcs-ref).

https://github.com/eclipse/jkube/blob/b294c87433532762234a61e95b3d939749b4aff8/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/GitEnricher.java#L57-L81

See also

@manusa manusa added this to the 1.0.0 milestone May 4, 2020
@manusa manusa added this to "Backlog" in Sprint #184 May 11, 2020
@manusa manusa moved this from "Backlog" to Planned in Sprint #184 May 13, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 26, 2020
@rohanKanojia rohanKanojia self-assigned this May 26, 2020
@rohanKanojia rohanKanojia moved this from Planned to In Progress in Sprint #184 May 26, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 1, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 1, 2020
@rohanKanojia rohanKanojia moved this from In Progress to Review in Sprint #184 Jun 1, 2020
@rohanKanojia rohanKanojia moved this from Review to Done in Sprint #184 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint #184
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants