New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PortForwardService to use Kubernetes Client Port Forwarding instead of kubectl binary #181
Labels
enhancement
New feature or request
Milestone
Comments
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Nov 27, 2020
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
12 tasks
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Nov 27, 2020
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Nov 30, 2020
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Nov 30, 2020
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Nov 30, 2020
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Nov 30, 2020
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Following are conclusions of the sync review:
High level view of PortForward/Debug mode:Conditions for port forward to work:
Before port forwarding
During port forwarding
|
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Dec 7, 2020
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jan 4, 2021
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Jan 11, 2021
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa
pushed a commit
to manusa/jkube
that referenced
this issue
Jan 11, 2021
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Merged
20 tasks
manusa
pushed a commit
to manusa/jkube
that referenced
this issue
Jan 12, 2021
…Client Port Forwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa
pushed a commit
that referenced
this issue
Jan 13, 2021
…orwarding instead of kubectl binary + Moved code from DebugMojo to DebugService + Refactored PortForwardService to use KubernetesClient's portForward instead of `kubectl`/`oc` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now
PortForwardService
which is used ink8s:debug
goal is just executing commandkubectl port-forward port..
. This works but won't work whenkubectl
oroc
binary is not available on system.https://github.com/eclipse/jkube/blob/9e3d67371e8c12bc8aa6288acacc83d1f796ea96/jkube-kit/config/service/src/main/java/org/eclipse/jkube/kit/config/service/PortForwardService.java#L227-L240
We should refactor it to use Fabric8 Kubernetes Client instead. Here is an example, PortForwardExample:
The text was updated successfully, but these errors were encountered: