Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hacktoberfest] PlatformMode fields may be 'final' #1837

Closed
1 task done
manusa opened this issue Oct 13, 2022 · 1 comment · Fixed by #1846
Closed
1 task done

[Hacktoberfest] PlatformMode fields may be 'final' #1837

manusa opened this issue Oct 13, 2022 · 1 comment · Fixed by #1846
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Milestone

Comments

@manusa
Copy link
Member

manusa commented Oct 13, 2022

Description

The following statement is reported as a code style issue:

https://github.com/eclipse/jkube/blob/c15c4bb8b7cc4ea7502f8314b1e067b27f9a1dda/jkube-kit/config/resource/src/main/java/org/eclipse/jkube/kit/config/resource/PlatformMode.java#L35

  • should be changed to:
    private final String label;

Before you start

Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! Hacktoberfest Issues accountable for the Hacktoberfest labels Oct 13, 2022
@dipesh-rawat
Copy link
Contributor

@manusa I could like to work on this. Could you please assign this to me.

dipesh-rawat added a commit to dipesh-rawat/jkube that referenced this issue Oct 13, 2022
Signed-off-by: Dipesh Rawat <Dipesh.rawat@ibm.com>
@manusa manusa added this to the 1.10.0 milestone Oct 13, 2022
manusa pushed a commit that referenced this issue Oct 13, 2022
Signed-off-by: Dipesh Rawat <Dipesh.rawat@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants