Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oc:remote-dev goal / ocRemoteDev task have wrong log prefixes #1935

Closed
rohanKanojia opened this issue Nov 23, 2022 · 0 comments · Fixed by #1952
Closed

oc:remote-dev goal / ocRemoteDev task have wrong log prefixes #1935

rohanKanojia opened this issue Nov 23, 2022 · 0 comments · Fixed by #1952
Assignees
@rohanKanojia
Labels
bug Something isn't working
Milestone
1.11.0

Comments

@rohanKanojia
Copy link
Member

Describe the bug

This is a minor inconsistency. Not sure whether this is a mistake or intentional.

Usually, OpenShift Maven/Gradle plugins have oc: prefix in their log statements. But Remote development goals have k8s log prefix. I think we're missing overriding getLogPrefix() method in OpenShiftRemoteDevMojo like done in other OpenShift Mojos.

Eclipse JKube version

other (please specify in additional context)

Component

OpenShift Maven Plugin

Apache Maven version

No response

Gradle version

No response

Steps to reproduce

Run mvn oc:remote-dev and see log prefix.

Expected behavior

log prefix should be oc

Runtime

OpenShift

Kubernetes API Server version

1.25.3

Environment

Linux

Eclipse JKube Logs

eclipse-jkube-demo-project-gradle : $ gradle ocRemoteDev

> Task :ocRemoteDev
k8s: Running generator spring-boot
k8s: spring-boot: Using Docker image quay.io/jkube/jkube-java:0.0.17 as base / builder
k8s: Waiting for JKube remote development Pod [jkube-remote-dev-c7bd29eb-8c4b-4677-9f06-82fd93cc6f24] to be ready...
k8s: JKube remote development Pod [jkube-remote-dev-c7bd29eb-8c4b-4677-9f06-82fd93cc6f24] is ready
k8s: Opening remote development connection to Kubernetes: jkube-remote-dev-c7bd29eb-8c4b-4677-9f06-82fd93cc6f24:57854

k8s: Local port '8080' is now available as a Kubernetes Service at eclipse-jkube-demo-project:8080

Sample Reproducer Project

No response

Additional context

No response
@rohanKanojia rohanKanojia added the bug Something isn't working label Nov 23, 2022
@manusa manusa added this to the 1.11.0 milestone Nov 24, 2022
@rohanKanojia rohanKanojia self-assigned this Dec 2, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Dec 2, 2022
@rohanKanojia
fix (openshift-plugins) : oc:remote-dev goal / ocRemoteDev task h…
4a95454 
…ave wrong log prefixes (eclipse-jkube#1935)

+ Override getLogPrefix() method in OpenShiftRemoteDevMojo to enforce
  OpenShift log prefix
+ Implement OpenShiftRemoteDevTask to enforce OpenShift log prefix

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Dec 2, 2022
Merged
17 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Dec 2, 2022
@rohanKanojia
fix (openshift-plugins) : oc:remote-dev goal / ocRemoteDev task h…
b35c25e 
…ave wrong log prefixes (eclipse-jkube#1935)

+ Override getLogPrefix() method in OpenShiftRemoteDevMojo to enforce
  OpenShift log prefix
+ Implement OpenShiftRemoteDevTask to enforce OpenShift log prefix

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Dec 5, 2022
@rohanKanojia @manusa
fix (openshift-plugins) : oc:remote-dev goal / ocRemoteDev task h…
4c2bc25 
…ave wrong log prefixes (#1935)

+ Override getLogPrefix() method in OpenShiftRemoteDevMojo to enforce
  OpenShift log prefix
+ Implement OpenShiftRemoteDevTask to enforce OpenShift log prefix

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
bug Something isn't working
Projects
None yet
Milestone
1.11.0
2 participants
@manusa @rohanKanojia