Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused methods from KubernetesResourceUtil #1974

Closed
1 task
rohanKanojia opened this issue Dec 23, 2022 · 3 comments · Fixed by #1976
Closed
1 task

Remove unused methods from KubernetesResourceUtil #1974

rohanKanojia opened this issue Dec 23, 2022 · 3 comments · Fixed by #1976
Assignees
Milestone

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

While working on #1316, I noticed there are many methods in KubernetesResourceUtil that are not used anywhere. Maybe they were used in past but lost references during refactors.

I think we should remove these unused methods.

Expected Behavior

We shouldn't have that many unused methods in KubernetesResourceUtil

Acceptance Criteria

  • Clean up KubernetesResourceUtil to remove unused methods
@anurag-rajawat
Copy link
Contributor

@rohanKanojia can I work on this?

@anurag-rajawat
Copy link
Contributor

@rohanKanojia there is one more unused method

KubernetesResourceUtil.getCreationTimestamp

do we need it or remove it?

@rohanKanojia
Copy link
Member Author

You can remove this as well.

anurag-rajawat added a commit to anurag-rajawat/jkube that referenced this issue Dec 23, 2022
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
@manusa manusa added this to the 1.11.0 milestone Jan 3, 2023
manusa pushed a commit that referenced this issue Jan 3, 2023
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants