Expression cycle detected

[vanpeter7]

Describe the bug

We have 2 variables in our pom.xml:

• git.build.version.tag (generated by git-commit-id-plugin with generateGitPropertiesFile and injectAllReactorProjects)
• image.tag referencing git.build.version.tag (like <image.tag>${git.build.version.tag}</image.tag>)

When using variable image.tag in our Dockerfile like ${image.tag}, kubernetes-maven-plugin gives the error "Expression cycle detected". There is no cycle though.

Eclipse JKube version

1.9.1

Component

Kubernetes Maven Plugin

Apache Maven version

3.8.1

Gradle version

None

Steps to reproduce

1. use 2 variables in your pom.xml like

• git.build.version.tag (generated by git-commit-id-plugin with generateGitPropertiesFile and injectAllReactorProjects)
• image.tag referencing git.build.version.tag (like <image.tag>${git.build.version.tag}</image.tag>)

2. use ${image.tag} variable in Dockerfile
3. build the Dockerfile

Expected behavior

image.tag should be resolved to the value of git.build.version.tag

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.25.3

Environment

macOS

Eclipse JKube Logs

Caused by: java.lang.IllegalArgumentException: Expression cycle detected, aborting.
    at org.eclipse.jkube.kit.common.JKubeFileInterpolator.checkPropertyWithDelimiters (JKubeFileInterpolator.java:137)
    at org.eclipse.jkube.kit.common.JKubeFileInterpolator.checkForPropertiesInLine (JKubeFileInterpolator.java:96)
    at org.eclipse.jkube.kit.common.JKubeFileInterpolator.interpolate (JKubeFileInterpolator.java:72)
    at org.eclipse.jkube.kit.common.JKubeFileInterpolator.interpolate (JKubeFileInterpolator.java:60)
    at org.eclipse.jkube.kit.build.api.helper.DockerFileUtil.extractLines (DockerFileUtil.java:111)
    at org.eclipse.jkube.kit.build.api.helper.DockerFileUtil.extractBaseImages (DockerFileUtil.java:67)
    at org.eclipse.jkube.kit.build.service.docker.BuildService.extractBaseFromDockerfile (BuildService.java:278)
    at org.eclipse.jkube.kit.build.service.docker.BuildService.autoPullBaseImage (BuildService.java:257)
    at org.eclipse.jkube.kit.build.service.docker.BuildService.buildImage (BuildService.java:75)

Sample Reproducer Project

No response

Additional context

No response

[BgaborBP]

We're also struggling with the same issue, and it's not really a cyclic dependency in our case, just a variable reference.

[manusa]

We've prioritized this issue, we'll try to provide a fix for v1.12.0

[rohanKanojia]

@PavelItel228 : Could you please add a comment here so that I can assign this issue to you?

[pavel1tel]

@rohanKanojia sure