Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Build mode #218

Closed
manusa opened this issue Jun 1, 2020 · 0 comments · Fixed by #244
Closed

Refactor Build mode #218

manusa opened this issue Jun 1, 2020 · 0 comments · Fixed by #244
Assignees
@rohanKanojia
Projects
Sprint #185 Sprint #186
Milestone
1.0.0

Comments

@manusa
Copy link
Member

manusa commented Jun 1, 2020

Description

Does having a kubernetes build mode make sense when we have separate plugins (openshift-maven-plugin & kubernetes-maven-plugin)?

What's the point of having mvn oc:build -Djkube.mode=kuberneteswhen we can always domvn k8s:build` even if we are running on an OpenShift cluster?
@manusa manusa added this to the 1.0.0 milestone Jun 1, 2020
@manusa manusa added this to "Backlog" in Sprint #185 Jun 1, 2020
@manusa manusa moved this from "Backlog" to Planned in Sprint #185 Jun 3, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 15, 2020
@rohanKanojia
Fix eclipse-jkube#218: Remove RuntimeMode mode parametere from Plugins
74c876d
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 15, 2020
@rohanKanojia
Fix eclipse-jkube#218: Remove RuntimeMode mode parametere from Plugins
6490421
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 15, 2020
@rohanKanojia
Fix eclipse-jkube#218: Remove RuntimeMode mode parametere from Plugins
b5929a1
@rohanKanojia rohanKanojia mentioned this issue Jun 15, 2020
Merged
11 tasks
@rohanKanojia rohanKanojia moved this from Planned to In progress in Sprint #185 Jun 15, 2020
@rohanKanojia rohanKanojia self-assigned this Jun 15, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 16, 2020
@rohanKanojia
Fix eclipse-jkube#218: Remove RuntimeMode mode parametere from Plugins
67c99e9
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 16, 2020
@rohanKanojia
Fix eclipse-jkube#218: Remove RuntimeMode mode parametere from Plugins
a4f0176
@manusa manusa moved this from In progress to Review in Sprint #185 Jun 19, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 25, 2020
@rohanKanojia
Fix eclipse-jkube#218: Remove RuntimeMode mode parametere from Plugins
b2e25f6
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 25, 2020
@rohanKanojia
Fix eclipse-jkube#218: Remove RuntimeMode mode parametere from Plugins
e74ab82
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 25, 2020
@rohanKanojia
Fix eclipse-jkube#218: Remove RuntimeMode mode parametere from Plugins
b04245e
@manusa manusa added this to Review in Sprint #186 Jun 25, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 25, 2020
@rohanKanojia
Fix eclipse-jkube#218: Remove RuntimeMode mode parametere from Plugins
a2638e4
Sprint #186 automation moved this from Review to Done Jun 25, 2020
manusa pushed a commit that referenced this issue Jun 25, 2020
@rohanKanojia @manusa
Fix #218: Remove RuntimeMode mode parametere from Plugins
b573deb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
None yet
Projects
No open projects
Sprint #185
  
Review
Sprint #186
  
Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Fix #218: Remove RuntimeMode mode parameter from Plugins rohanKanojia/jkube
2 participants
@manusa @rohanKanojia