Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s:resource doesn't automatically pick up port from Quarkus application.properties #2239

Closed
rohanKanojia opened this issue Jun 23, 2023 · 2 comments · Fixed by #2287
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Jun 23, 2023

Describe the bug

In a Quarkus project, when I specify port via application.properties:

quarkus.http.port=9000

k8s:build does pick up this port and exposes 9000 port in container image. However, k8s:resource doesn't seem to add 9000 port in generated Kubernetes liveness, readiness and startup probes.

If I add extra jkube-healthcheck-quarkus enricher configuration for port, it works:

      <plugin>
          <groupId>org.eclipse.jkube</groupId>
          <artifactId>kubernetes-maven-plugin</artifactId>
          <version>${jkube.version}</version>              
          <configuration>
            <enricher>
              <config>
                  <jkube-healthcheck-quarkus>
                      <port>9000</port>
                  </jkube-healthcheck-quarkus>
              </config>
            </enricher>  
          </configuration>
      </plugin>

Eclipse JKube version

1.13.1

Component

Kubernetes Maven Plugin

Apache Maven version

None

Gradle version

None

Steps to reproduce

  1. Enable health support in Quarkus project
  2. Override default HTTP port via properties
  3. Run k8s:resource, generated manifests contains probes containing 8080 port

Expected behavior

Port should be automatically detected from properties while generating health checks

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.25.3

Environment

Linux

Eclipse JKube Logs

No response

Sample Reproducer Project

No response

Additional context

No response

@rohanKanojia rohanKanojia added the bug Something isn't working label Jun 23, 2023
@asingh2295
Copy link
Contributor

@rohanKanojia
Please assign this issue to me.

@rohanKanojia
Copy link
Member Author

@asingh2295 : Thanks for showing interest.

You need to make changes in QuarkusHealthCheckEnricher

I've done same changes for Helidon in #2235

asingh2295 added a commit to asingh2295/jkube that referenced this issue Jul 18, 2023
asingh2295 added a commit to asingh2295/jkube that referenced this issue Jul 18, 2023
Signed-off-by: Ankit Singh <ankit2.singh@samsung.com>
asingh2295 added a commit to asingh2295/jkube that referenced this issue Jul 18, 2023
Signed-off-by: Ankit Singh <ankit2.singh@samsung.com>
asingh2295 added a commit to asingh2295/jkube that referenced this issue Jul 18, 2023
Signed-off-by: Ankit Singh <ankit2.singh@samsung.com>
rohanKanojia pushed a commit to asingh2295/jkube that referenced this issue Jul 27, 2023
Signed-off-by: Ankit Singh <ankit2.singh@samsung.com>
rohanKanojia pushed a commit to asingh2295/jkube that referenced this issue Jul 31, 2023
Signed-off-by: Ankit Singh <ankit2.singh@samsung.com>
rohanKanojia pushed a commit to asingh2295/jkube that referenced this issue Aug 23, 2023
Signed-off-by: Ankit Singh <ankit2.singh@samsung.com>
@manusa manusa added this to the 1.14.0 milestone Aug 24, 2023
manusa pushed a commit that referenced this issue Aug 24, 2023
Signed-off-by: Ankit Singh <ankit2.singh@samsung.com>
manusa added a commit to manusa/jkube that referenced this issue Aug 24, 2023
manusa added a commit that referenced this issue Aug 24, 2023
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment