Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile custom interpolation is broken #246

Closed
manusa opened this issue Jun 17, 2020 · 0 comments · Fixed by #271
Closed

Dockerfile custom interpolation is broken #246

manusa opened this issue Jun 17, 2020 · 0 comments · Fixed by #271
Assignees
@rohanKanojia
Labels
bug Something isn't working
Projects
Sprint #186
Milestone
1.0.0

Comments

@manusa
Copy link
Member

manusa commented Jun 17, 2020 •
edited

Description

After #80, Dockerfile interpolation configured by BuildConfiguration#filter is now broken. Custom separators (or disabling) is no longer working since the new JKubeDockerfileInterpolator is not configurable.

Tests should be ported from docker-maven-plugin so that behavior is exactly the same as FixedStringSearchInterpolator with tests.

According to documentation, interpolator configuration can be any of:

  • No configuration StringUtils.isBlank(BuildConfiguration#filter)
  • Disabled (<filter>false</filter>) BuildConfiguration#filter equalsIgnoreCase("false")
  • Custom interpolator (single character or prefix*suffix): <filter>@</filter>, <filter>${*}</filter>

See DMP logic.
@manusa manusa added the bug Something isn't working label Jun 17, 2020
@manusa manusa added this to the 1.0.0 milestone Jun 17, 2020
@manusa manusa added this to Backlog in Sprint #186 Jun 22, 2020
@manusa manusa moved this from Backlog to Planned in Sprint #186 Jun 25, 2020
@rohanKanojia rohanKanojia self-assigned this Jun 29, 2020
@manusa manusa moved this from Planned to In progress in Sprint #186 Jun 29, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 29, 2020
@rohanKanojia
Fix eclipse-jkube#246
dc7d36e
Sprint #186 automation moved this from In progress to Done Jul 1, 2020
@rohanKanojia rohanKanojia reopened this Jul 1, 2020
@rohanKanojia rohanKanojia moved this from Done to In progress in Sprint #186 Jul 1, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 1, 2020
@rohanKanojia
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
c64942c
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 1, 2020
@rohanKanojia
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
3a82c40
@rohanKanojia rohanKanojia moved this from In progress to Review in Sprint #186 Jul 1, 2020
@rohanKanojia rohanKanojia mentioned this issue Jul 3, 2020
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 3, 2020
@rohanKanojia
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
41ffcb3
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 3, 2020
@rohanKanojia
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
fb35e86
@manusa manusa moved this from Review to In progress in Sprint #186 Jul 7, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 7, 2020
@rohanKanojia
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
e6e7d05
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 7, 2020
@rohanKanojia
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
dfc1f7f
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 7, 2020
@rohanKanojia
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
4133324
@manusa manusa moved this from In progress to Review in Sprint #186 Jul 8, 2020
Sprint #186 automation moved this from Review to Done Jul 8, 2020
rohanKanojia added a commit that referenced this issue Jul 8, 2020
@rohanKanojia
Fix #246: Dockerfile custom interpolation is broken
3673b6d
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
@rohanKanojia
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
c73a496 
Signed-off-by: Tue Dissing <tue.dissing@ufst.dk>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
@rohanKanojia @TueDissingWork
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
86e7b6a
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
@rohanKanojia @TueDissingWork
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
3b7c282
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
@rohanKanojia @TueDissingWork
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
911df91
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
@rohanKanojia @TueDissingWork
Fix eclipse-jkube#246: Dockerfile custom interpolation is broken
2528aa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
bug Something isn't working
Projects
No open projects
Sprint #186
  
Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Fix #246: Dockerfile custom interpolation is broken rohanKanojia/jkube
2 participants
@manusa @rohanKanojia