Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageName should be able to parse image names with IPv6 address literals #2541

Closed
1 task
rohanKanojia opened this issue Jan 11, 2024 · 0 comments · Fixed by #2642
Closed
1 task

ImageName should be able to parse image names with IPv6 address literals #2541

rohanKanojia opened this issue Jan 11, 2024 · 0 comments · Fixed by #2642
Labels
bug Something isn't working
Milestone

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Jan 11, 2024

Task description

Description

Currently, ImageName only accepts domain names or IPv4 literals in the registry name.

However, parsing IPv6 literals support was added Docker Distrubution Reference.

We should modify our registry host regular expressions to accommodate IPv6 addresses.

Distribution's Regexp can be seen in regexp.go

domainName = domainNameComponent + anyTimes(`\.`+domainNameComponent)
ipv6address = `\[(?:[a-fA-F0-9:]+)\]`

host = `(?:` + domainName + `|` + ipv6address + `)`

Expected Behavior

ImageName should be able to parse image name with registry having IPv6 literal (e.g [2001:db8::1]:5000/repo:tag)

Acceptance Criteria

  • ImageName validation logic is modified to handle IPv6 addresses
@manusa manusa added the bug Something isn't working label Jan 11, 2024
@manusa manusa added this to the 1.16.0 milestone Feb 9, 2024
manusa added a commit to manusa/jkube that referenced this issue Feb 9, 2024
Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa added a commit that referenced this issue Feb 9, 2024
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment