Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift-maven-plugin does not update Routes #267

Closed
mtrejo-zz opened this issue Jun 29, 2020 · 0 comments · Fixed by #279
Closed

openshift-maven-plugin does not update Routes #267

mtrejo-zz opened this issue Jun 29, 2020 · 0 comments · Fixed by #279
Labels
bug Something isn't working
Milestone

Comments

@mtrejo-zz
Copy link
Contributor

Description

I originally found this issue in FMP fabric8:apply goal, I have yet to use the new plugin but just by looking at the code I can see the issue still exists in JKube.

The plugin will only create a Route if it doesn't exist and do nothing otherwise, here is the corresponding code in FMP:
https://github.com/fabric8io/fabric8-maven-plugin/blob/master/core/src/main/java/io/fabric8/maven/core/service/ApplyService.java#L668-L690
And the same code in JKube:
https://github.com/eclipse/jkube/blob/master/jkube-kit/config/service/src/main/java/org/eclipse/jkube/kit/config/service/ApplyService.java#L646-L668

Info

  • Maven version (mvn -v) :
Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z)
Java version: 1.8.0_242, vendor: AdoptOpenJDK
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.10.0-1127.13.1.el7.x86_64", arch: "amd64", family: "unix"
  • Kubernetes / Red Hat OpenShift setup and version :
    OpenShift 4.3

  • If it's a bug, how to reproduce :

  1. Create a project with a Route resource fragment.
  2. Deploy to OpenShift mvn oc:deploy.
  3. Make any change to the Route resource fragment.
  4. Redeploy.
  5. oc describe route <route>, not updated.
@manusa manusa added the bug Something isn't working label Jun 30, 2020
@manusa manusa modified the milestones: 1.0.0, 1.1.0 Jun 30, 2020
mtrejo-zz pushed a commit to mtrejo-zz/jkube that referenced this issue Jul 5, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
mtrejo-zz pushed a commit to mtrejo-zz/jkube that referenced this issue Jul 10, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
manusa pushed a commit that referenced this issue Jul 16, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
manusa pushed a commit that referenced this issue Jul 16, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
Signed-off-by: Tue Dissing <tue.dissing@ufst.dk>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
Signed-off-by: Tue Dissing <tue.dissing@ufst.dk>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
TueDissingWork pushed a commit to TueDissingWork/jkube that referenced this issue Jul 28, 2020
Signed-off-by: Marcos Trejo <marcos.trejo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants