Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyConfigHandler doesn't seem to be used - in Gradle #296

Closed
manusa opened this issue Jul 17, 2020 · 2 comments · Fixed by #3042
Closed

PropertyConfigHandler doesn't seem to be used - in Gradle #296

manusa opened this issue Jul 17, 2020 · 2 comments · Fixed by #3042
Assignees
Labels
bug Something isn't working
Milestone

Comments

@manusa
Copy link
Member

manusa commented Jul 17, 2020

Description

PropertyConfigHandler seems to be completely ignored, same as DockerComposeConfigHandler.

Functionality in ImageConfigResolver#resolve seems to be also something useless at the moment: https://github.com/eclipse/jkube/blob/9db93fb42d1dcade59278ce8f1b433b869e0927d/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/config/handler/ImageConfigResolver.java#L72-L87

Apparently this is something that's already advised/warned in the docs:

https://github.com/eclipse/jkube/blob/9db93fb42d1dcade59278ce8f1b433b869e0927d/kubernetes-maven-plugin/doc/src/main/asciidoc/inc/_introduction.adoc#L215-L218
image

But the code responsible for this has been included in the project nonetheless.

We need to reevaluate if this code+functionality is relevant in the project and act accordingly.

@manusa manusa added this to the 1.1.0 milestone Aug 3, 2020
@manusa manusa modified the milestones: 1.1.0, 1.2.0 Jan 12, 2021
@manusa manusa modified the milestones: 1.2.0, 1.3.0 Mar 31, 2021
@manusa manusa modified the milestones: 1.3.0, 1.4.0 May 7, 2021
@manusa manusa modified the milestones: 1.4.0, 1.x Jul 27, 2021
@manusa
Copy link
Member Author

manusa commented Jul 14, 2023

It's actually used through the ImageConfigResolver class.

However, since this class relies on Plexus (Maven) injection, it might not be working as expected for Gradle

@manusa manusa added the bug Something isn't working label Jul 14, 2023
@manusa manusa changed the title PropertyConfigHandler doesn't seem to be used PropertyConfigHandler doesn't seem to be used - in Gradle Jul 14, 2023
@manusa manusa self-assigned this May 8, 2024
@manusa manusa modified the milestones: 1.x, 1.17.0 May 8, 2024
@manusa
Copy link
Member Author

manusa commented May 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant