-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some test cases in IoUtilTest class fails on Macos #3001
Comments
@arman-yekkehkhani : Thanks for reporting!
If it's a small change, go ahead and go it. If it's slightly bigger change maybe you want to discuss on this issue first. |
@arman-yekkehkhani : Maybe we can also add a GitHub Action workflow for MacOS build. We can create a separate task for this. |
…t with subdirectories, issue eclipse-jkube#3001 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
…t with subdirectories, issue eclipse-jkube#3001 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
@rohanKanojia |
@arman-yekkehkhani : Adding a macOS workflow just means adding a GitHub Action YAML file similar to existing workflows in |
However, this is mostly internal work. We'll take care of this ourselves, thanks! |
…t with subdirectories, issue eclipse-jkube#3001 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com> (cherry picked from commit 2442766)
@rohanKanojia I have attached a PR. Could you please take a look at it? |
… path, issue eclipse-jkube#3001 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
@arman-yekkehkhani : Unfortunately, I don't have access to MacOS environment where I can test your fix. Could you please attach some screenshot/ GitHub Action log to verify that it's working on MacOS? |
@rohanKanojia Here are the screenshot and logs when I run tests locally for module logs:
|
This comment was marked as outdated.
This comment was marked as outdated.
@rohanKanojia Yeah 👍 |
…ationTest (#3001) Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
Describe the bug
When running tests in
org.eclipse.jkube.kit.common.util.IoUtilTest
, some test cases fail with a message similar to the following one:After reading the implementation of method
fileTree
in classFileAssertions
, I found out that the relative path of files in the file tree is not computed correctly on MacOS.P.S. Fixed the issue. Shall I create a PR for it?
Eclipse JKube version
SNAPSHOT
Component
JKube Kit
Apache Maven version
None
Gradle version
None
Steps to reproduce
mvn clean test
insidejkube-jit
moduleExpected behavior
Tests inside class
IoUtilTest
should all pass.Runtime
other (please specify in additional context)
Kubernetes API Server version
1.25.3
Environment
macOS
Eclipse JKube Logs
No response
Sample Reproducer Project
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: