Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WildFly Bootable JAR - Add native support for slim Bootable JAR #385

Closed
jfdenise opened this issue Sep 17, 2020 · 2 comments
Closed

WildFly Bootable JAR - Add native support for slim Bootable JAR #385

jfdenise opened this issue Sep 17, 2020 · 2 comments
Milestone

Comments

@jfdenise
Copy link
Contributor

jfdenise commented Sep 17, 2020

Description

Thanks to JKube workflow, we have the opportunity to benefit from slim Bootable JAR (a Bootable JAR that doesn't contain JBoss modules artifacts) feature. slim Bootable JAR starts fast, this wil lreduce the server startup time.

The WildFlyJar Generator can detect the path to the generated maven repo cache configured in the wildfly-jar-maven-plugin and installs it in the Docker image in /deployments/[directory name].

In addition, the generator adds the -Dmaven.local.repo=/deployments/[directory name] in the JAVA_OPTIONS. That is required for the server to retrieve JBoss modules artifacts. NB: In order for this part to work properly we need a fix for #384

Info

  • Eclipse JKube version :1.0.0
@manusa
Copy link
Member

manusa commented Sep 23, 2020

Hi @jfdenise
#384 has been closed via #395.
Besides the aforementioned option, it would be nice to include the -Djava.net.preferIPv4Stack=true option too, so that project using the plugin don't need to manually add this.

jfdenise added a commit to jfdenise/jkube that referenced this issue Sep 23, 2020
…pport for slim Bootable JAR

Signed-off-by: JF Denise <jdenise@redhat.com>
jfdenise added a commit to jfdenise/jkube that referenced this issue Sep 23, 2020
…pport for slim Bootable JAR

Signed-off-by: JF Denise <jdenise@redhat.com>
jfdenise added a commit to jfdenise/jkube that referenced this issue Sep 23, 2020
…pport for slim Bootable JAR

Signed-off-by: JF Denise <jdenise@redhat.com>
jfdenise added a commit to jfdenise/jkube that referenced this issue Sep 23, 2020
…pport for slim Bootable JAR

Signed-off-by: JF Denise <jdenise@redhat.com>
jfdenise added a commit to jfdenise/jkube that referenced this issue Sep 23, 2020
…pport for slim Bootable JAR

Signed-off-by: JF Denise <jdenise@redhat.com>
jfdenise added a commit to jfdenise/jkube that referenced this issue Sep 23, 2020
…pport for slim Bootable JAR

Signed-off-by: JF Denise <jdenise@redhat.com>
jfdenise added a commit to jfdenise/jkube that referenced this issue Sep 28, 2020
…pport for slim Bootable JAR

Signed-off-by: JF Denise <jdenise@redhat.com>
manusa pushed a commit that referenced this issue Sep 29, 2020
…m Bootable JAR

Signed-off-by: JF Denise <jdenise@redhat.com>
@manusa
Copy link
Member

manusa commented Oct 5, 2020

Implemented in #398

@manusa manusa closed this as completed Oct 5, 2020
@manusa manusa added this to the 1.0.1 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants