Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress generations fails, TLS issue? #387

Closed
semanticfire opened this issue Sep 19, 2020 · 3 comments · Fixed by #498
Closed

Ingress generations fails, TLS issue? #387

semanticfire opened this issue Sep 19, 2020 · 3 comments · Fixed by #498
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@semanticfire
Copy link
Contributor

semanticfire commented Sep 19, 2020

Description

I cannot get Ingress support working with both the XML method and with the Resource Fragment option

If I use the following fragment (which works on my k8s instance):

apiVersion: networking.k8s.io/v1
metadata:
  name: my-ingress
  annotations:
    ingress.kubernetes.io/rewrite-target: /
    cert-manager.io/cluster-issuer: "letsencrypt-prod"
spec:
  tls:
  - hosts:
    - my.host.com
    secretName: letsencrypt-prod
  rules:
  - host: my.host.com
    http:
      paths:
        - path: /
          pathType: Prefix
          backend:
            service:
              name: my-service
              port: 
                number: 8080

I get the following error:
Execution default-cli of goal org.eclipse.jkube:kubernetes-maven-plugin:1.0.0:resource failed: No resource type found for:networking.k8s.io/v1#Ingress

Info

  • Eclipse JKube version : 1.0.0

  • Maven version (mvn -v) : 3.6.0

  • Kubernetes / Red Hat OpenShift setup and version :
    Kubernetes 1.19

  • If it's a bug, how to reproduce :
    add the above fragment in src/main/jkube/ingress.yaml and you'll get the error.

  • If it's a feature request, what is your use case :

@semanticfire
Copy link
Contributor Author

After some further playing around I remembered the message on my k8s console about the deprecation of the extensions/v1beta1 apiVersion for Ingress so I switched to networking.k8s.io/v1 switching this back solved my problem!

This needs to be fixed in future versions

@manusa manusa added the bug Something isn't working label Sep 30, 2020
@manusa manusa added this to the 1.0.2 milestone Sep 30, 2020
@manusa manusa added this to Backlog in Sprint #191 Oct 5, 2020
@manusa manusa moved this from Backlog to Planned in Sprint #191 Oct 8, 2020
@rohanKanojia
Copy link
Member

I think this problem is due to Fabric8 Kubernetes Client not supporting networking.k8s.io/v1 Ingress. There is a PR already for upgrading Kubernetes Model to v1.19.1(with networking.k8s.io/v1 Ingress added to the model): fabric8io/kubernetes-client#2541 . I think we need to wait for it to get merged and update the Fabric8 Kubernetes Client version in Eclipse JKube to resolve this issue.

@manusa manusa modified the milestones: 1.0.2, 1.1.0 Oct 15, 2020
@manusa manusa added enhancement New feature or request and removed bug Something isn't working labels Oct 15, 2020
@manusa
Copy link
Member

manusa commented Oct 15, 2020

Blocked by: Upgrade to Fabric8 Kubernetes Client 4.13.0 (TBD)

@manusa manusa moved this from Planned to In progress in Sprint #191 Oct 15, 2020
@manusa manusa moved this from In progress to Backlog in Sprint #191 Oct 15, 2020
@manusa manusa added this to Backlog in Sprint #192 Oct 27, 2020
@manusa manusa moved this from Backlog to Planned in Sprint #192 Oct 28, 2020
@rohanKanojia rohanKanojia moved this from Planned to In progress in Sprint #192 Nov 17, 2020
@rohanKanojia rohanKanojia self-assigned this Nov 17, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 17, 2020
This should also fix eclipse-jkube#387

+ Updated Kubernetes Client to v4.13.0
+ Added a test to verify `networking.k8s.io/v1` `Ingress` is loaded
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 17, 2020
This should also fix eclipse-jkube#387

+ Updated Kubernetes Client to v4.13.0
+ Added a test to verify `networking.k8s.io/v1` `Ingress` is loaded
@rohanKanojia rohanKanojia moved this from In progress to Review in Sprint #192 Nov 18, 2020
@manusa manusa added this to Review in Sprint #193 Nov 18, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 26, 2020
This should also fix eclipse-jkube#387

+ Updated Kubernetes Client to v4.13.0
+ Added a test to verify `networking.k8s.io/v1` `Ingress` is loaded
Sprint #193 automation moved this from Review to Done Nov 27, 2020
manusa pushed a commit that referenced this issue Nov 27, 2020
This should also fix #387

+ Updated Kubernetes Client to v4.13.0
+ Added a test to verify `networking.k8s.io/v1` `Ingress` is loaded
alexdeveng pushed a commit to alexdeveng/jkube that referenced this issue Dec 24, 2020
This should also fix eclipse-jkube#387

+ Updated Kubernetes Client to v4.13.0
+ Added a test to verify `networking.k8s.io/v1` `Ingress` is loaded
@manusa manusa mentioned this issue Feb 4, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Sprint #191
  
Backlog
Sprint #192
  
Review
Sprint #193
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants