Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cacheFrom configuration parameter is missing #484

Closed
edrandall opened this issue Nov 9, 2020 · 2 comments · Fixed by #503
Closed

cacheFrom configuration parameter is missing #484

edrandall opened this issue Nov 9, 2020 · 2 comments · Fixed by #503
Assignees
Labels
bug Something isn't working
Projects

Comments

@edrandall
Copy link

Description

Info

  • Eclipse JKube version : 1.0.2
  • Maven version (mvn -v) :
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/apache-maven-3.6.3
Java version: 11.0.7, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.7", arch: "x86_64", family: "mac"
  • Kubernetes / Red Hat OpenShift setup and version :
oc v3.11.0+0cbc58b
kubernetes v1.11.0+d4cacc0
features: Basic-Auth

Server https://**REDACTED**:8443
openshift v3.11.69
kubernetes v1.11.0+d4cacc0
  • If it's a bug, how to reproduce :
    Migrated an existing working io.fabric8:fabric8-maven-plugin:4.4.1 configuration to org.eclipse.jkube:kubernetes-maven-plugin:1.0.2
    Build configuration contains
							<configuration>
								<images>
									<image>
										<build>
											<cacheFrom>${image.cache-from.uri}</cacheFrom>

mvn install results in this error:

[ERROR] Failed to execute goal org.eclipse.jkube:kubernetes-maven-plugin:1.0.2:build (container-build) on project **REDACTED**-builder: Unable to parse configuration of mojo org.eclipse.jkube:kubernetes-maven-plugin:1.0.2:build for parameter cacheFrom: Cannot find 'cacheFrom' in class org.eclipse.jkube.kit.config.image.build.BuildConfiguration -> [Help 1]

The cacheFrom config element is described in jKube documentation at: https://www.eclipse.org/jkube/docs/kubernetes-maven-plugin#config-image
and was described in in fabric8-maven-plugin at: https://maven.fabric8.io/#config-image-build
However it seems to be absent from BuildConfiguration.java.

  • If it's a feature request, what is your use case :
    It's a defect, not a feature request, but the use-case is, when building within a per-job docker-tooling-container environment, such as GitLab docker-in-docker, there is no local docker cache containing prior builds of the same image. Therefore it's necessary to "seed" the cache with the last-known good build from the main repository (a separate step in the gitlab pipeline) and then use "cacheFrom" to instruct fabric8/jkube/docker to use that image as a source of prior layers - this improves performance a great deal.

  • Sample Reproducer Project : [GitHub Clone URL]

@rohanKanojia
Copy link
Member

ah, sorry for the inconvenience caused. We'll fix this.

@manusa manusa added the bug Something isn't working label Nov 9, 2020
@manusa
Copy link
Member

manusa commented Nov 9, 2020

Thx for reporting

@manusa manusa added this to Backlog in Sprint #193 Nov 16, 2020
@manusa manusa moved this from Backlog to Planned in Sprint #193 Nov 18, 2020
@rohanKanojia rohanKanojia self-assigned this Nov 19, 2020
@manusa manusa moved this from Planned to In progress in Sprint #193 Nov 20, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 26, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 26, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 27, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 27, 2020
@rohanKanojia rohanKanojia moved this from In progress to Review in Sprint #193 Nov 27, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Dec 3, 2020
Sprint #193 automation moved this from Review to Done Dec 4, 2020
manusa pushed a commit that referenced this issue Dec 4, 2020
- Fix #484: CacheFrom parameter is missing in BuildConfiguration

- Add @Singular annotation to cacheFrom in BuildConfiguration
alexdeveng pushed a commit to alexdeveng/jkube that referenced this issue Dec 24, 2020
…ration (eclipse-jkube#503)

- Fix eclipse-jkube#484: CacheFrom parameter is missing in BuildConfiguration

- Add @Singular annotation to cacheFrom in BuildConfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Sprint #193
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants