Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.maven-dockerignore, .maven-dockerexclude, .maven-dockerinclude are no longer supported #529

Closed
cooltea713705 opened this issue Dec 23, 2020 · 0 comments · Fixed by #567
Closed

.maven-dockerignore, .maven-dockerexclude, .maven-dockerinclude are no longer supported #529

cooltea713705 opened this issue Dec 23, 2020 · 0 comments · Fixed by #567
Assignees
@rohanKanojia
Labels
bug Something isn't working
Projects
Sprint #196 Sprint #197
Milestone
1.2.0

Comments

@cooltea713705
Copy link

cooltea713705 commented Dec 23, 2020 •
edited

Description

.maven-dockerignore is not supported even though the documentation (5.2.5 Build Configuration) states that the presence of such file should allow excluding files. After analysis of the code it seems like the following commit has removed the feature. By extension, .maven-dockerexclude and .maven-dockerinclude look like they would not work either.

Info

  • Eclipse JKube version : >=1.0.1
@manusa manusa added the bug Something isn't working label Jan 12, 2021
@manusa manusa added this to Backlog in Sprint #196 Jan 18, 2021
@manusa manusa moved this from Backlog to Planned in Sprint #196 Jan 20, 2021
@manusa manusa mentioned this issue Jan 25, 2021
Closed
@rohanKanojia rohanKanojia self-assigned this Feb 2, 2021
@rohanKanojia rohanKanojia moved this from Planned to In progress in Sprint #196 Feb 3, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Feb 3, 2021
@rohanKanojia
Fix eclipse-jkube#529: .maven-dockerignore, .maven-dockerexclude,…
e664711 
… `.maven-dockerinclude` are no longer supported

Added `.jkube-dockerignore`, `.jkube-dockerexclude` and
`.jkube-dockerinclude` in AssemblyManager while creating
Dockerfile assembly configuration
@rohanKanojia rohanKanojia mentioned this issue Feb 3, 2021
Merged
12 tasks
@rohanKanojia rohanKanojia moved this from In progress to Review in Sprint #196 Feb 4, 2021
@rohanKanojia rohanKanojia mentioned this issue Feb 4, 2021
Closed
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Feb 9, 2021
@rohanKanojia
Fix eclipse-jkube#529: .maven-dockerignore, .maven-dockerexclude,…
27c52c5 
… `.maven-dockerinclude` are no longer supported

Added `.jkube-dockerignore`, `.jkube-dockerexclude` and
`.jkube-dockerinclude` in AssemblyManager while creating
Dockerfile assembly configuration
@manusa manusa added this to Review in Sprint #197 Feb 10, 2021
@manusa manusa mentioned this issue Mar 1, 2021
Closed
Sprint #197 automation moved this from Review to Done Mar 2, 2021
manusa pushed a commit that referenced this issue Mar 2, 2021
@rohanKanojia @manusa
Fix #529: .maven-dockerignore, .maven-dockerexclude, `.maven-dock…
cc8a208 
…erinclude` are no longer supported

Added `.jkube-dockerignore`, `.jkube-dockerexclude` and
`.jkube-dockerinclude` in AssemblyManager while creating
Dockerfile assembly configuration
@manusa manusa added this to the 1.2.0 milestone Mar 11, 2021
@manusa manusa mentioned this issue Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
bug Something isn't working
Projects
No open projects
Sprint #196
  
Review
Sprint #197
  
Done
Milestone
1.2.0
3 participants
@manusa @cooltea713705 @rohanKanojia