Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kubernetes Client to 5.1.1 #592

Closed
apupier opened this issue Mar 1, 2021 · 5 comments · Fixed by #593
Closed

Upgrade Kubernetes Client to 5.1.1 #592

apupier opened this issue Mar 1, 2021 · 5 comments · Fixed by #593

Comments

@apupier
Copy link
Contributor

apupier commented Mar 1, 2021

Description

currently using 5.0.0 https://github.com/eclipse/jkube/blob/35999caee8736d69a5d3cc6dc6589287e3e7fb3b/jkube-kit/parent/pom.xml#L56

Info

  • Eclipse JKube version :
  • Maven version (mvn -v) :

  • Kubernetes / Red Hat OpenShift setup and version :

  • If it's a bug, how to reproduce :

  • If it's a feature request, what is your use case :

  • Sample Reproducer Project : [GitHub Clone URL]

apupier added a commit to apupier/jkube that referenced this issue Mar 1, 2021
and align (transitive) dependencies

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/jkube that referenced this issue Mar 1, 2021
and align (transitive) dependencies

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@rohanKanojia
Copy link
Member

rohanKanojia commented Mar 1, 2021

Hmm, When I testing jkube with 5.2-SNAPSHOT, I was able to resolve this with these changes:

https://github.com/eclipse/jkube/compare/master...rohanKanojia:pr/upgrade-fabric8-5-1-0?expand=1

Could you please try migrating to java.util.Base64 and see if it works for you?

apupier added a commit to apupier/jkube that referenced this issue Mar 1, 2021
- align (transitive) dependencies
- use Base64 instead of javax.xml.bind.DatatypeConverter to have it
working with java 11

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Contributor Author

apupier commented Mar 1, 2021

Could you please try migrating to java.util.Base64 and see if it works for you?

it is fixing the compile issue. thanks.

remains a test that is failing #593 (comment)

com.fasterxml.jackson.dataformat.yaml.snakeyaml.error.MarkedYAMLException: while parsing a block mapping
 in 'reader', line 6, column 5:
        app: test
        ^
expected <block end>, but found '<scalar>'
 in 'reader', line 9, column 34:
        helm-variable: "(( required "A valid .Values.global_template_ ... 
                                     ^

 at [Source: (StringReader); line: 9, column: 34]

@rohanKanojia
Copy link
Member

ohk, let me try to take a look into it as soon as I finish my current task.

@apupier
Copy link
Contributor Author

apupier commented Mar 1, 2021

I printed the actual and expected content on which it is failing. i tis for the openshift/templates/test-pod.yaml

the genrated one contaisn effectively a problem:

---
apiVersion: v1
kind: Pod
metadata:
  labels:
    app: test
    provider: jkube
    version: "1337"
    helm-variable: "{{ required "A valid .Values.global_template_env_var entry required!" .Values.global_template_env_var | default "This is a sample" }}"
  name: test
spec:
  containers:
  - env:
    - name: SAMPLE_ENV_VAR
      value: "${SAMPLE_ENV_VAR}"
    - name: KUBERNETES_NAMESPACE
      valueFrom:
        fieldRef:
          fieldPath: metadata.namespace
    image: dockerfile/redis
    imagePullPolicy: IfNotPresent
    name: master
    ports:
    - containerPort: 8080
      name: http
      protocol: TCP
    - containerPort: 9779
      name: prometheus
      protocol: TCP
    - containerPort: 8778
      name: jolokia
      protocol: TCP
    securityContext:
      privileged: false

the line helm-variable: "{{ required "A valid .Values.global_template_env_var entry required!" .Values.global_template_env_var | default "This is a sample" }}" is using double-quotes to enclose the value although there are doubcle-quotes inside the value.

@manusa manusa added this to Review in Sprint #197 Mar 2, 2021
@manusa manusa linked a pull request Mar 2, 2021 that will close this issue
12 tasks
manusa pushed a commit to apupier/jkube that referenced this issue Mar 3, 2021
- align (transitive) dependencies
- use Base64 instead of javax.xml.bind.DatatypeConverter to have it
working with java 11

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@manusa manusa added this to Review in Sprint #198 Mar 3, 2021
apupier added a commit to apupier/jkube that referenced this issue Mar 5, 2021
- align (transitive) dependencies
- use Base64 instead of javax.xml.bind.DatatypeConverter to have it
working with java 11

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
manusa pushed a commit to apupier/jkube that referenced this issue Mar 5, 2021
- align (transitive) dependencies
- use Base64 instead of javax.xml.bind.DatatypeConverter to have it
working with java 11

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Sprint #198 automation moved this from Review to Done Mar 5, 2021
manusa pushed a commit that referenced this issue Mar 5, 2021
- align (transitive) dependencies
- use Base64 instead of javax.xml.bind.DatatypeConverter to have it
working with java 11

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint #197
  
Review
Sprint #198
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants