Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused field in ResourceConfig #673

Closed
rohanKanojia opened this issue Apr 20, 2021 · 3 comments · Fixed by #692
Closed

Unused field in ResourceConfig #673

rohanKanojia opened this issue Apr 20, 2021 · 3 comments · Fixed by #692
Projects
Sprint #201
Milestone
1.3.0

Comments

@rohanKanojia
Copy link
Member

While revisiting ResourceConfig, I discovered this field is not used anywhere:

https://github.com/eclipse/jkube/blob/3af6339ddfa16efbe42ef6e71687f583d74856ee/jkube-kit/config/resource/src/main/java/org/eclipse/jkube/kit/config/resource/ResourceConfig.java#L68

Shall we remove this field if it's not getting used anywhere?
@manusa
Copy link
Member

manusa commented Apr 20, 2021 •
edited

Sure.
However, we should first see if this port is used in FMP and double check we won't have compatibility issues in case users upgrade from FMP to JKube.
(Plus remove any documentation, quickstart, etc. that might be referencing the field)

@manusa manusa added this to the 1.3.0 milestone Apr 20, 2021
@manusa manusa added this to Planned in Sprint #201 May 7, 2021
@rohanKanojia
Copy link
Member Author

I checked in FMP codebase and this field seems unused there as well. I think we should remove it

@manusa
Copy link
Member

manusa commented May 7, 2021

I checked in FMP codebase and this field seems unused there as well. I think we should remove it

Go ahead ;)

rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 7, 2021
@rohanKanojia
Fix eclipse-jkube#673: Remove unused ports mapping field from Resourc…
680f09b 
…eConfig

ResourceConfig's port mapping doesn't seem to be getting used anywhere
neither there is any documentation about it's usage. I only see port
configuration via ServiceConfig or via <image> configuration.
@rohanKanojia rohanKanojia mentioned this issue May 7, 2021
Merged
12 tasks
@rohanKanojia rohanKanojia moved this from Planned to Review in Sprint #201 May 10, 2021
Sprint #201 automation moved this from Review to Done May 10, 2021
manusa pushed a commit that referenced this issue May 10, 2021
@rohanKanojia @manusa
Fix #673: Remove unused ports mapping field from ResourceConfig
1b99e59 
ResourceConfig's port mapping doesn't seem to be getting used anywhere
neither there is any documentation about it's usage. I only see port
configuration via ServiceConfig or via <image> configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Sprint #201
  
Done
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Chore #673: Remove unused ports mapping field from ResourceConfig rohanKanojia/jkube
2 participants
@manusa @rohanKanojia