Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesPushTask: Implement k8s:push equivalent functionality k8sPush for Kubernetes Gradle Plugin #935

Closed
1 task done
rohanKanojia opened this issue Sep 24, 2021 · 0 comments · Fixed by #942
Closed
1 task done
Assignees
Labels
component/gradle-plugin Related to the Gradle Plugins
Milestone

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Sep 24, 2021

Description

Child of #31
Blocked by #934

Port PushMojo from Maven Plugins to KubernetesPushTask in gradle plugins.

  • Any functionality present in maven plugins should be moved to gradle plugins
  • Common initialization logic between KubernetesBuildTask and KubernetesPushTask should be moved to some helper class
  • k8sBuild task should have precedence over k8sPush. This should be defined in KubernetesPlugin class getTaskPrecedence() method.
@manusa manusa added this to Planned in Sprint #207 Sep 27, 2021
@manusa manusa added the component/gradle-plugin Related to the Gradle Plugins label Sep 27, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 28, 2021
…`k8sPush` for Kubernetes Gradle Plugin

Kubernetes Push Task ported to gradle

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia self-assigned this Sep 28, 2021
@rohanKanojia rohanKanojia moved this from Planned to In progress in Sprint #207 Sep 28, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 28, 2021
…`k8sPush` for Kubernetes Gradle Plugin

Kubernetes Push Task ported to gradle

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to Planned in Sprint #208 Sep 29, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 29, 2021
…`k8sPush` for Kubernetes Gradle Plugin

Kubernetes Push Task ported to gradle

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 29, 2021
…`k8sPush` for Kubernetes Gradle Plugin

Kubernetes Push Task ported to gradle

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 29, 2021
…`k8sPush` for Kubernetes Gradle Plugin

Kubernetes Push Task ported to gradle

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 29, 2021
…`k8sPush` for Kubernetes Gradle Plugin

Kubernetes Push Task ported to gradle

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Sep 29, 2021
… Kubernetes Gradle Plugin

Kubernetes Push Task ported to gradle

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa moved this from Planned to In progress in Sprint #208 Sep 29, 2021
@manusa manusa moved this from In progress to Review in Sprint #208 Sep 29, 2021
@manusa manusa closed this as completed Oct 3, 2021
Sprint #208 automation moved this from Review to Done Oct 3, 2021
manusa pushed a commit that referenced this issue Oct 11, 2021
… Kubernetes Gradle Plugin

Kubernetes Push Task ported to gradle

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Oct 19, 2021
… Kubernetes Gradle Plugin

Kubernetes Push Task ported to gradle

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to the 1.5.0 milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/gradle-plugin Related to the Gradle Plugins
Projects
No open projects
Sprint #207
  
In progress
Sprint #208
  
Done
2 participants