Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IngressEnricher's opinionated path type is too restrictive #975

Closed
1 task done
manusa opened this issue Oct 6, 2021 · 4 comments · Fixed by #999
Closed
1 task done

IngressEnricher's opinionated path type is too restrictive #975

manusa opened this issue Oct 6, 2021 · 4 comments · Fixed by #999
Assignees
Labels
good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Milestone

Comments

@manusa
Copy link
Member

manusa commented Oct 6, 2021

Description

While adding configuration options to the IngressEnricher (#551), we also included new functionality to be able to convert Ingresses from one Api Group (networking.k8s.io/v1 / extensions/v1beta1) (#723).

This change introduced the pathType field which is mandatory in v1. However, as default value we added Exact which is too restrictive. We should replace this value so that we delegate the setting to the Ingress Controller (just like it happens in extensions/v1beta1). This means replacing Exact with ImplementationSpecific.

The following code fragment:

https://github.com/eclipse/jkube/blob/82319bd54a52a0525d0c889fe3bea6c1b99176ed/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/NetworkingV1IngressGenerator.java#L115

  • should be changed to:
                            .withPathType("ImplementationSpecific")

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@manusa manusa added good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest labels Oct 6, 2021
@manusa manusa added this to the 1.5.0 milestone Oct 6, 2021
@Onyinye91-ctrl
Copy link
Contributor

Onyinye91-ctrl commented Oct 6, 2021

@manusa please can i take this

@manusa
Copy link
Member Author

manusa commented Oct 13, 2021

Fixed by #999

@manusa manusa closed this as completed Oct 13, 2021
@Onyinye91-ctrl
Copy link
Contributor

@manusa Thanks for the assistance and not getting tired of me. I appreciate

@manusa
Copy link
Member Author

manusa commented Oct 14, 2021

@manusa Thanks for the assistance and not getting tired of me. I appreciate

😄 That's all part of the Hacktoberfest and good-first-issues spirit and duties. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Projects
None yet
2 participants