Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration options to IngressEnricher #551

Closed
manusa opened this issue Jan 27, 2021 · 1 comment · Fixed by #723
Closed

Add configuration options to IngressEnricher #551

manusa opened this issue Jan 27, 2021 · 1 comment · Fixed by #723
Assignees
@rohanKanojia
Labels
enhancement New feature or request
Projects
Sprint #197 Sprint #198 Sprint #199 Sprint #200 Sprint #201 Sprint #202 Sprint #203 Sprint #204
Milestone
1.4.0

Comments

@manusa
Copy link
Member

manusa commented Jan 27, 2021 •
edited
Loading

Description

IngressEnricher should provide configuration options TBD.

These options should allow users to create opinionated Ingresses with a simple configuration such as:

<properties>
   <jkube.createExternalUrls>true</jkube.createExternalUrls>
   <jkube.enricher.jkube-ingress.host>test.192.168.49.2.nip.io</jkube.enricher.jkube-ingress.host>
</properties>

Relates to:
@manusa manusa added this to the 1.2.0 milestone Jan 27, 2021
@manusa manusa added the enhancement New feature or request label Jan 27, 2021
@manusa
Copy link
Member Author

manusa commented Feb 5, 2021 •
edited
Loading

As discussed in this Gitter thread (February 5, 2021 11:40 AM), target API should be configurable too.

Other options to consider is default Ingress API to use and cluster compatibility detection.

@manusa manusa added this to Backlog in Sprint #197 Feb 8, 2021
@manusa manusa moved this from Backlog to Planned in Sprint #197 Feb 10, 2021
@manusa manusa added this to Backlog in Sprint #198 Mar 3, 2021
@manusa manusa moved this from Backlog to Planned in Sprint #198 Mar 3, 2021
@manusa manusa added this to Planned in Sprint #199 Mar 24, 2021
@manusa manusa modified the milestones: 1.2.0, 1.3.0 Mar 31, 2021
@manusa manusa added this to Planned in Sprint #200 Apr 14, 2021
@manusa manusa mentioned this issue Apr 26, 2021
Merged
12 tasks
@manusa manusa added this to Planned in Sprint #201 May 5, 2021
@manusa manusa modified the milestones: 1.3.0, 1.4.0 May 18, 2021
@manusa manusa added this to Planned in Sprint #202 May 26, 2021
@rohanKanojia rohanKanojia self-assigned this Jun 14, 2021
@manusa manusa moved this from Planned to In progress in Sprint #202 Jun 14, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 14, 2021
@rohanKanojia
Fix eclipse-jkube#551: Add Configuration options to IngressEnricher
08283fd 
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 15, 2021
@rohanKanojia
Fix eclipse-jkube#551: Add Configuration options to IngressEnricher
dea9187 
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Jun 15, 2021
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 15, 2021
@rohanKanojia
Fix eclipse-jkube#551: Add Configuration options to IngressEnricher
b65f60a 
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa moved this from In progress to Review in Sprint #202 Jun 16, 2021
@manusa manusa added this to Review in Sprint #203 Jun 16, 2021
@rohanKanojia rohanKanojia moved this from Review to In progress in Sprint #203 Jun 21, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 21, 2021
@rohanKanojia
Fix eclipse-jkube#551: Add Configuration options to IngressEnricher
e4c6754 
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 21, 2021
@rohanKanojia
Fix eclipse-jkube#551: Add Configuration options to IngressEnricher
ccfef5f 
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia moved this from In progress to Review in Sprint #203 Jun 22, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 2, 2021
@rohanKanojia
Fix eclipse-jkube#551: Add Configuration options to IngressEnricher
0664c98 
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to Review in Sprint #204 Jul 7, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 21, 2021
@rohanKanojia
Fix eclipse-jkube#551: Add Configuration options to IngressEnricher
b879410 
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit to rohanKanojia/jkube that referenced this issue Jul 26, 2021
@rohanKanojia @manusa
Fix eclipse-jkube#551: Add Configuration options to IngressEnricher
0927c09 
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa mentioned this issue Jul 26, 2021
Open
4 tasks
Sprint #204 automation moved this from Review to Done Jul 26, 2021
manusa pushed a commit that referenced this issue Jul 26, 2021
@rohanKanojia @manusa
Fix #551: Add Configuration options to IngressEnricher
7b5d157 
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa mentioned this issue Oct 6, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
enhancement New feature or request
Projects
No open projects
Sprint #197
  
Planned
Sprint #198
  
Planned
Sprint #199
  
Planned
Sprint #200
  
Planned
Sprint #201
  
Planned
Sprint #202
  
Review
Sprint #203
  
Review
Sprint #204
  
Done
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Fix #551: Add Configuration options to IngressEnricher rohanKanojia/jkube
2 participants
@manusa @rohanKanojia