Fix #802: Update Fabric8 Kubernetes Client to v5.10.1 #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1120 +/- ##
============================================
- Coverage 49.08% 48.94% -0.15%
+ Complexity 3642 3606 -36
============================================
Files 458 456 -2
Lines 20778 20709 -69
Branches 2829 2824 -5
============================================
- Hits 10199 10135 -64
- Misses 9495 9498 +3
+ Partials 1084 1076 -8
Continue to review full report at Codecov.
|
rohanKanojia
force-pushed
the
pr/issue802
branch
2 times, most recently
from
ab63472
to
4b83328
Compare
manusa
reviewed
Nov 16, 2021
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/KubernetesHelper.java
Outdated
Show resolved
Hide resolved
rohanKanojia
force-pushed
the
pr/issue802
branch
from
4b83328
to
24f1197
Compare
13 tasks
rohanKanojia
force-pushed
the
pr/issue802
branch
4 times, most recently
from
ee7b69e
to
af66535
Compare
manusa
reviewed
Nov 17, 2021
| private static boolean isGenericCustomResourceCompatible(Class<?> clazz){ | ||
| return clazz.isAssignableFrom(GenericCustomResource.class); | ||
| private static boolean isGenericKubernetesResourceCompatible(Class<?> clazz){ | ||
| return clazz.isAssignableFrom(GenericKubernetesResource.class); |
manusa
reviewed
Nov 17, 2021
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/KubernetesHelper.java
Outdated
Show resolved
Hide resolved
manusa
reviewed
Nov 17, 2021
jkube-kit/config/service/src/main/java/org/eclipse/jkube/kit/config/service/ApplyService.java
Outdated
Show resolved
Hide resolved
manusa
reviewed
Nov 17, 2021
...ava/org/eclipse/jkube/kit/config/service/openshift/OpenshiftBuildServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
rohanKanojia
force-pushed
the
pr/issue802
branch
2 times, most recently
from
0267896
to
391271d
Compare
manusa
reviewed
Nov 17, 2021
...vice/src/main/java/org/eclipse/jkube/kit/config/service/kubernetes/KubernetesClientUtil.java
Outdated
Show resolved
Hide resolved
rohanKanojia
force-pushed
the
pr/issue802
branch
3 times, most recently
from
2856e04
to
b32b2f8
Compare
manusa
reviewed
Nov 17, 2021
...vice/src/main/java/org/eclipse/jkube/kit/config/service/kubernetes/KubernetesClientUtil.java
Outdated
Show resolved
Hide resolved
manusa
reviewed
Nov 17, 2021
...-kit/config/service/src/test/java/org/eclipse/jkube/kit/config/service/ApplyServiceTest.java
Show resolved
Hide resolved
+ Update Fabric8 Kubernetes Client to v5.10.1 + Remove GenericCustomResource from project and replace it with GenericKubernetesResource(provided by Fabric8 Kubernetes Client) + Refactor ApplyService#applyGenericKubernetesResource CustomResourceDefinition discovery logic to use genericKubernetesResources(apiVersion, kind) method instead + Update Framework CustomResourceDefinition manifest in Spring Boot CRD Quickstart to apiextensions.k8s.io/v1 from apiextensions.k8s.io/v1beta1 Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…OpenShiftMockServer Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue802
branch
from
b32b2f8
to
cbdb089
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #802
+Refactor
ApplyService#applyGenericKubernetesResourceCustomResourceDefinition discovery logic to usegenericKubernetesResources(apiVersion, kind)method insteadapiextensions.k8s.io/v1fromapiextensions.k8s.io/v1beta1CQs:
Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist