feat: helm Parameters/Variables/Values.yaml can be configured via XML/DSL #1244

manusa · 2022-01-28T14:08:17Z

Description

feat: helm Parameters/Variables/Values.yaml can be configured via XML/DSL

Instead of providing parameters via Template resource fragment, they can now be provided via pom.xml XML configuration or build.gadle DSL configuration.

The following configuration:

<helm>
  <parameters>
    <parameter>
      <name>chart_name</name>
      <value>{{ .Chart.Name }}</value>
    </parameter>
  </parameters>
</helm>

Can interpolate a resource fragment:

metadata:
 annotations:
   chart/name: ${chart_name}

To produce a:

apiVersion: v1
kind: #...
metadata:
  annotations:
   chart/name: {{ .Chart.Name }}
# ...

Type of change

Bug fix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change
Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)

Checklist

I have read the contributing guidelines
I signed-off my commit with a user that has signed the Eclipse Contributor Agreement
I Added CHANGELOG entry
I have implemented unit tests to cover my changes
I have updated the documentation accordingly
No new bugs, code smells, etc. in SonarCloud report
I tested my code in Kubernetes
I tested my code in OpenShift

/cc @dloiacono

manusa · 2022-01-28T14:08:37Z

Eclipse JKube CI Report

Started new GH workflow run for #1244 (2022-02-01T06:39:43Z)

⚙️ JKube E2E Tests (1776725213)

codecov · 2022-01-28T14:19:35Z

Codecov Report

Merging #1244 (2502caf) into master (165cff7) will increase coverage by 0.06%.
The diff coverage is 97.91%.

@@             Coverage Diff              @@
##             master    #1244      +/-   ##
============================================
+ Coverage     50.57%   50.63%   +0.06%     
- Complexity     3734     3751      +17     
============================================
  Files           458      458              
  Lines         20637    20671      +34     
  Branches       2809     2812       +3     
============================================
+ Hits          10437    10467      +30     
- Misses         9103     9108       +5     
+ Partials       1097     1096       -1

Impacted Files	Coverage Δ
...lipse/jkube/kit/resource/helm/HelmServiceUtil.java	`70.54% <50.00%> (ø)`
.../java/org/eclipse/jkube/kit/common/Maintainer.java	`80.00% <100.00%> (+8.57%)`	⬆️
...ava/org/eclipse/jkube/kit/common/util/MapUtil.java	`88.67% <100.00%> (+5.82%)`	⬆️
...rg/eclipse/jkube/kit/resource/helm/HelmConfig.java	`97.91% <100.00%> (+0.04%)`	⬆️
...g/eclipse/jkube/kit/resource/helm/HelmService.java	`95.23% <100.00%> (+0.36%)`	⬆️
...it/config/service/portforward/PortForwardTask.java	`60.00% <0.00%> (-4.00%)`	⬇️
...e/jkube/kit/config/service/PortForwardService.java	`70.10% <0.00%> (-3.10%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165cff7...2502caf. Read the comment docs.