chore: Deprecate maven.jkube.io annotation prefix from enrichers
#1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1245 +/- ##
============================================
+ Coverage 50.17% 50.18% +0.01%
- Complexity 3699 3705 +6
============================================
Files 457 457
Lines 20605 20618 +13
Branches 2805 2807 +2
============================================
+ Hits 10338 10347 +9
- Misses 9182 9184 +2
- Partials 1085 1087 +2
Continue to review full report at Codecov.
|
rohanKanojia
force-pushed
the
pr/deprecate-maven-jkube-io-annotation
branch
from
0780a3b
to
589a05e
Compare
manusa
reviewed
Jan 28, 2022
...enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/ConfigMapEnricherTest.java
Outdated
Show resolved
Hide resolved
rohanKanojia
force-pushed
the
pr/deprecate-maven-jkube-io-annotation
branch
from
589a05e
to
8c9765e
Compare
manusa
reviewed
Jan 31, 2022
...her/generic/src/test/java/org/eclipse/jkube/enricher/generic/FileDataSecretEnricherTest.java
Outdated
Show resolved
Hide resolved
`maven.jkube.io` seems to be a side effect of search-replace during migration from FMP to JKube. Deprecate all annotation properties starting with this prefix. Introduce use of `jkube.eclipse.org` prefix instead. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/deprecate-maven-jkube-io-annotation
branch
from
8c9765e
to
beabba8
Compare
manusa
approved these changes
Jan 31, 2022
|
SonarCloud Quality Gate failed. |
This was referenced Jan 31, 2022
sunix
approved these changes
Jan 31, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
maven.jkube.ioseems to be a side effect of search-replace duringmigration from FMP to JKube. Deprecate all annotation properties
starting with this prefix.
Introduce the use of
jkube.eclipse.orgprefix instead.Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist