New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(jkube-kit/config): Refactoring DockerFileBuilder collections to be final #1827
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #1827 (2022-10-13T15:57:33Z) ⚙️ JKube E2E Tests (3243630331)
|
K8S v1.24.0 quarkus (#1827) seems to be timing out trying to get dependency from repo1.maven.org
|
@manusa are there any changes that are required? |
@singloon : ECA check is failing. Have you created Eclipse account and signed Eclipse Contributor Agreement? |
@singloon : Are you sure you used same email as the one linked in commit/PR description? |
@rohanKanojia fixed |
… to be final Signed-off-by: Ka Lan Leung <kalanleung@outlook.com>
SonarCloud Quality Gate failed. |
Codecov Report
@@ Coverage Diff @@
## master #1827 +/- ##
============================================
- Coverage 53.00% 52.99% -0.02%
+ Complexity 3938 3937 -1
============================================
Files 464 464
Lines 20745 20745
Branches 2809 2809
============================================
- Hits 10996 10993 -3
- Misses 8623 8625 +2
- Partials 1126 1127 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Signed-off-by: Ka Lan Leung kalanleung@outlook.com
Description
Fixes #1807
Type of change
test, version modification, documentation, etc.)
Checklist