fix: BaseGenerator retrieves runtime mode from context #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Runtime mode was being computed from System properties that were never set in the first place (this is specific to ResourceMojo) - TODO: Refactor BaseEnricher so it behaves like BaseGenerator (not critical because it works as the properties are there for enrichers) Signed-off-by: Marc Nuri <marc@marcnuri.com>
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=========================================
Coverage 26.22% 26.22%
- Complexity 1576 1577 +1
=========================================
Files 350 350
Lines 18275 18276 +1
Branches 2806 2807 +1
=========================================
+ Hits 4792 4793 +1
+ Misses 12926 12925 -1
- Partials 557 558 +1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
rohanKanojia
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
were never set in the first place (this is specific to ResourceMojo)
(not critical because it works as the properties are there for
enrichers)