Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WebAppGenerator Jetty handler uses jkube/jkube-jetty9-binary-s2i for Docker and S2I builds #210

Merged
merged 1 commit into from May 25, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented May 25, 2020

Relates to #183

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #210 into master will increase coverage by 0.03%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #210      +/-   ##
============================================
+ Coverage     26.73%   26.76%   +0.03%     
- Complexity     1620     1626       +6     
============================================
  Files           350      350              
  Lines         18310    18308       -2     
  Branches       2803     2801       -2     
============================================
+ Hits           4895     4900       +5     
+ Misses        12853    12848       -5     
+ Partials        562      560       -2     
Impacted Files Coverage Δ Complexity Δ
...nerator/webapp/handler/CustomAppServerHandler.java 52.94% <0.00%> (-3.31%) 2.00 <0.00> (ø)
...enerator/webapp/handler/TomcatAppSeverHandler.java 81.81% <ø> (-3.90%) 10.00 <0.00> (-3.00)
...nerator/webapp/handler/WildFlyAppSeverHandler.java 85.71% <ø> (-1.25%) 22.00 <0.00> (-2.00)
...generator/webapp/handler/JettyAppSeverHandler.java 83.33% <83.33%> (+58.33%) 11.00 <11.00> (+8.00)
...lipse/jkube/generator/webapp/AppServerHandler.java 83.33% <100.00%> (+33.33%) 5.00 <3.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4adb57...f3bea60. Read the comment docs.

…i for Docker and S2I builds

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa force-pushed the feature/webapp-jetty-images branch from fdf258c to f3bea60 Compare May 25, 2020 10:36
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

93.3% 93.3% Coverage
3.2% 3.2% Duplication

@manusa manusa mentioned this pull request May 25, 2020
@manusa manusa merged commit 8fc6f14 into eclipse-jkube:master May 25, 2020
@manusa manusa deleted the feature/webapp-jetty-images branch May 25, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant