test (gradle-plugin/it) : Add test for setting ServiceAccount name in generated controller (#2187) #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2188 (2023-05-31T14:37:29Z) ⚙️ JKube E2E Tests (5133924218)
|
manusa
reviewed
May 31, 2023
Comment on lines
28
to
34
| enricher { | ||
| config { | ||
| 'jkube-serviceaccount' { | ||
| skipCreate = true | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
ServiceAccountEnricher seems to create additional ServiceAccount resource referenced in Deployment. This flag tells ServiceAccountEnricher to not do so.
There was a problem hiding this comment.
I've removed skipCreate configuration.
manusa
reviewed
May 31, 2023
| static Stream<Arguments> testInput() { | ||
| return Stream.of( | ||
| // arguments("no-fragment", new String[] {}), | ||
| // arguments("fragment", new String[] {"-Pjkube.resourceDir=./regularFragmentDir"}), |
There was a problem hiding this comment.
From the test expectations, the assumption here is that a fragment with an unrelated field has no action over the serviceAccountName field, right?
Could we state this more clearly? A simple "fragment" seems to convey the opposite assumption (I have a fragment with a service account -> what we test in the next case). So maybe an unrelated-fragment name might be more suitable.
There was a problem hiding this comment.
I've renamedfragment -> unrelated-fragment
Codecov Report
@@ Coverage Diff @@
## master #2188 +/- ##
=========================================
Coverage 57.82% 57.82%
Complexity 4398 4398
=========================================
Files 485 485
Lines 21114 21114
Branches 2802 2802
=========================================
Hits 12209 12209
Misses 7675 7675
Partials 1230 1230 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
… generated controller (eclipse-jkube#2187) Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/test-2187
branch
from
d6be6b8
to
c7e7818
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
manusa
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test case covering #2187
Failing cases have been commented. I'll remove comment in #1889
Type of change
test, version modification, documentation, etc.)
Checklist