Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Red Hat specific image support #220

Merged

Conversation

manusa
Copy link
Member

@manusa manusa commented Jun 2, 2020

Relates to: #183

@manusa manusa mentioned this pull request Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #220 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #220      +/-   ##
============================================
+ Coverage     27.12%   27.27%   +0.15%     
  Complexity     1665     1665              
============================================
  Files           352      353       +1     
  Lines         18335    18360      +25     
  Branches       2803     2800       -3     
============================================
+ Hits           4973     5008      +35     
+ Misses        12799    12789      -10     
  Partials        563      563              
Impacted Files Coverage Δ Complexity Δ
.../org/eclipse/jkube/generator/api/FromSelector.java 100.00% <ø> (+30.23%) 5.00 <0.00> (-1.00) ⬆️
...se/jkube/generator/javaexec/JavaExecGenerator.java 83.00% <ø> (ø) 22.00 <0.00> (ø)
...pse/jkube/generator/api/support/BaseGenerator.java 61.76% <100.00%> (-1.10%) 27.00 <8.00> (-4.00)
...nerator/webapp/handler/WildFlyAppSeverHandler.java 85.71% <100.00%> (ø) 22.00 <0.00> (ø)
.../eclipse/jkube/generator/api/GeneratorContext.java 33.33% <0.00%> (-8.34%) 4.00% <0.00%> (-1.00%)
.../eclipse/jkube/generator/karaf/KarafGenerator.java 95.91% <0.00%> (ø) 6.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11be290...050bafb. Read the comment docs.

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa force-pushed the fix/remove-redhat-specific-images branch from 8f7d2f9 to 050bafb Compare June 2, 2020 12:48
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa manusa merged commit 3b51d34 into eclipse-jkube:master Jun 2, 2020
@manusa manusa deleted the fix/remove-redhat-specific-images branch June 2, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants