refactor (jkube-kit/common) : Refactor IoUtil.getFreeRandomPort to always generate a valid free random port (#2501)
#2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2641 (2024-02-08T13:38:17Z) ⚙️ JKube E2E Tests (7830367131)
|
|
We're bumping into same issue as #2576 on Eclipse Jenkins due to usage of ServerSocket. I'm not able to reproduce this failure locally with JDK I'm disabling this test on JDK8 |
…always generate a valid free random port (eclipse-jkube#2501) + Use ServerSocket to establish a connection instead of Socket which might also throw ConnectException for a socket already in use. + Modify IoUtilTes.findOpenPortWithSmallAttemptsCount to use `@RepeatedTest` annotation to run it 500 times Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue2501
branch
from
8d76acc
to
753d2ef
Compare
manusa
reviewed
Feb 8, 2024
| @@ -64,7 +67,7 @@ void findOpenPortWhenPortsAreBusy() throws IOException { | |||
| assertThat(port2).isGreaterThan(port); | |||
| } | |||
|
|
|||
| @Test | |||
| @RepeatedTest(500) | |||
There was a problem hiding this comment.
Issue is not reproducible on single run, Running it multiple times reproduces the issue. This @RepeatedTest(500) verifies that test passes with new changes.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2641 +/- ##
=============================================
+ Coverage 59.36% 70.42% +11.05%
- Complexity 4586 4992 +406
=============================================
Files 500 486 -14
Lines 21211 19446 -1765
Branches 2830 2504 -326
=============================================
+ Hits 12591 13694 +1103
+ Misses 7370 4526 -2844
+ Partials 1250 1226 -24 ☔ View full report in Codecov by Sentry. |
manusa
approved these changes
Feb 9, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2501
@RepeatedTestannotation to run it 500 timesType of change
test, version modification, documentation, etc.)
Checklist