Update KubernetesLogTaskTest.java #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AjaySDwivedi1
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #2740 (2024-03-05T06:01:00Z) ⚙️ JKube E2E Tests (8151649292)
|
|
build is failing due to #2742 |
|
@AjaySDwivedi1 : Could you please rebase your branch against master? |
Sorry this might seem like a dumb question, but what does rebase mean? Is it similar to merging? |
|
@AjaySDwivedi1 : You're right, git rebase is somewhat similar to git merge, it's really handy when your branch gets outdated with newly pushed changes in main branch. |
There is a small issue right now. The laptop I use is not working, so I won't be able to do that as of right now. Do I need to do another PR after the rebase? |
|
You don't need to create another pull request, you can rebase and force push to the existing branch. |
Deleted the exception Signed-off-by: Ajay Dwivedi <adwived@clemson.edu>
rohanKanojia
force-pushed
the
AjaySDwivedi1-patch-6
branch
from
73d4ade
to
6d946a0
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2740 +/- ##
=============================================
+ Coverage 59.36% 70.57% +11.21%
- Complexity 4586 5012 +426
=============================================
Files 500 486 -14
Lines 21211 19457 -1754
Branches 2830 2504 -326
=============================================
+ Hits 12591 13732 +1141
+ Misses 7370 4502 -2868
+ Partials 1250 1223 -27 ☔ View full report in Codecov by Sentry. |
manusa
approved these changes
Mar 5, 2024
rohanKanojia
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2672
Type of change
test, version modification, documentation, etc.)
Checklist