#2847 OpenShift route generated targetPort doesn't use the service "targetPort" #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidemasi
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #2850 (2024-03-26T19:38:19Z) ⚙️ JKube E2E Tests (8441756189)
|
luigidemasi
force-pushed
the
#2847
branch
2 times, most recently
from
9e901fd
to
deafac5
Compare
manusa
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Changes look good to me.
However, some of the integration tests are failing:
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] ExposeIT.ocResource_whenRun_generatesOpenShiftManifestsWithProjectLabels:105 » IllegalArgument JSONArray size mismatch for JSON entry 'items', expected '7' but was '5'
[ERROR] MultipleServicesIT.ocResource_whenRun_generatesOpenShiftManifests:53 » IllegalArgument Values not equal for entry: 'targetPort', expected '80' but was '9376'
[ERROR] RouteNameAndFragmentIT.ocResourceTask:42 » IllegalArgument Values not equal for entry: 'targetPort', expected '9090' but was '8080'
[ERROR] ServiceNameAndFragmentIT.ocResourceTask:58 » IllegalArgument Values not equal for entry: 'targetPort', expected '9090' but was '8080'
[ERROR] VolumePermissionIT.ocResourceTask_whenRun_generatesOpenShiftManifestWithPersistentVolume:75 » IllegalArgument Values not equal for entry: 'targetPort', expected '80' but was '5000'
[ERROR] VolumePermissionIT.ocResourceTask_whenRun_generatesOpenShiftManifestWithPersistentVolume:75 » IllegalArgument Values not equal for entry: 'targetPort', expected '80' but was '5000'
[ERROR] VolumePermissionIT.ocResourceTask_whenRun_generatesOpenShiftManifestWithPersistentVolume:75 » IllegalArgument Values not equal for entry: 'targetPort', expected '80' but was '5000'
Failures are likely due to invalid expectations.
You also need to sign the ECA so that we are able to merge these changes.
Let me know if you need any help with any of the 2 missing tasks.
…he service "targetPort"
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2850 +/- ##
=============================================
+ Coverage 59.36% 70.62% +11.25%
- Complexity 4586 5017 +431
=============================================
Files 500 486 -14
Lines 21211 19466 -1745
Branches 2830 2507 -323
=============================================
+ Hits 12591 13747 +1156
+ Misses 7370 4494 -2876
+ Partials 1250 1225 -25 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2847
According to Openshift API specification,
spec.port.targetPorthave to be set with the target port of the service that the route try to expose:At the moment, openshift maven plugin use service set the route targetPort to service port.
https://docs.openshift.com/container-platform/4.15/rest_api/network_apis/route-route-openshift-io-v1.html#spec-port
Type of change