-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Refactored configurations #291
Conversation
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
============================================
+ Coverage 31.43% 32.72% +1.29%
- Complexity 1998 2078 +80
============================================
Files 360 362 +2
Lines 18532 18508 -24
Branches 2767 2737 -30
============================================
+ Hits 5825 6057 +232
+ Misses 12005 11737 -268
- Partials 702 714 +12
Continue to review full report at Codecov.
|
c5a67fd
to
46f1d20
Compare
b5bc520
to
b2940eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 , Thanks!
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/_authentication.adoc
Outdated
Show resolved
Hide resolved
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/push/_overview.adoc
Outdated
Show resolved
Hide resolved
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/push/_overview.adoc
Outdated
Show resolved
Hide resolved
- Unified property resolution for Generators and Enrichers +more - Fixed NameEnricher, now sets name for all HasMetadata objects - Removed code-smells regarding Config names and property defaults - Added new test suites for ProcessorConfig, DebugEnricher, DefaultNamespaceEnricher, NameEnricher, WildFlySwarmHealthCheckEnricher, QuarkusHealthCheckEnricher - Added missing tests for some enrichers - Refactored Vert.x Health Check Enricher so it behaves like the rest (can also read standard properties now) - Renamed properties with pattern `docker` prefix Signed-off-by: Marc Nuri <marc@marcnuri.com>
b2940eb
to
69b9f69
Compare
Kudos, SonarCloud Quality Gate passed!
|
Description
docker
prefixIn order to close #248 an additional PR will be submitted to unify and provide consistency to all configuration sections in the plugin documentation.
Type of change
test, version modification, documentation, etc.)
Checklist