Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Refactored configurations #291

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jul 15, 2020

Description

  • Unified property resolution for Generators and Enrichers
  • Fixed NameEnricher, now sets name for all HasMetadata objects
  • Removed code-smells regarding Config names and property defaults
  • Added new test suites for ProcessorConfig, DebugEnricher, DefaultNameEnricher, NameEnricher, QuarkusHealthCheckEnricher
  • Added missing tests for some enrichers
  • Refactored Vert.x Health Check Enricher so it behaves like the rest (can also read standard properties now)
  • Renamed properties with pattern docker prefix

In order to close #248 an additional PR will be submitted to unify and provide consistency to all configuration sections in the plugin documentation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #291 into master will increase coverage by 1.29%.
The diff coverage is 84.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #291      +/-   ##
============================================
+ Coverage     31.43%   32.72%   +1.29%     
- Complexity     1998     2078      +80     
============================================
  Files           360      362       +2     
  Lines         18532    18508      -24     
  Branches       2767     2737      -30     
============================================
+ Hits           5825     6057     +232     
+ Misses        12005    11737     -268     
- Partials        702      714      +12     
Impacted Files Coverage Δ Complexity Δ
...pi/auth/handler/FromConfigRegistryAuthHandler.java 72.72% <ø> (ø) 3.00 <0.00> (ø)
...api/auth/handler/OpenShiftRegistryAuthHandler.java 59.42% <ø> (ø) 15.00 <0.00> (ø)
...uth/handler/SystemPropertyRegistryAuthHandler.java 94.73% <ø> (ø) 4.00 <0.00> (ø)
...uild/service/docker/helper/ImageNameFormatter.java 94.11% <ø> (ø) 11.00 <0.00> (ø)
.../service/docker/helper/StartContainerExecutor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...kit/config/service/kubernetes/JibBuildService.java 48.00% <ø> (ø) 6.00 <0.00> (ø)
...g/eclipse/jkube/kit/enricher/api/BaseEnricher.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...clipse/jkube/kit/enricher/api/EnricherContext.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...e/jkube/kit/enricher/api/JKubeEnricherContext.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...se/jkube/kit/enricher/api/model/Configuration.java 0.00% <ø> (-39.14%) 0.00 <0.00> (-2.00)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e5948d...69b9f69. Read the comment docs.

@manusa manusa force-pushed the fix/configurations branch 7 times, most recently from c5a67fd to 46f1d20 Compare July 16, 2020 05:54
@manusa manusa changed the title WIP: Refactored configurations Fix: Refactored configurations Jul 16, 2020
@manusa manusa marked this pull request as ready for review July 16, 2020 05:55
@manusa manusa force-pushed the fix/configurations branch 3 times, most recently from b5bc520 to b2940eb Compare July 16, 2020 09:01
Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 , Thanks!

- Unified property resolution for Generators and Enrichers +more
- Fixed NameEnricher, now sets name for all HasMetadata objects
- Removed code-smells regarding Config names and property defaults
- Added new test suites for ProcessorConfig, DebugEnricher, DefaultNamespaceEnricher, NameEnricher,
  WildFlySwarmHealthCheckEnricher, QuarkusHealthCheckEnricher
- Added missing tests for some enrichers
- Refactored Vert.x Health Check Enricher so it behaves like the rest (can also read standard properties now)
- Renamed properties with pattern `docker` prefix

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

80.9% 80.9% Coverage
0.7% 0.7% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa manusa merged commit 682cc6f into eclipse-jkube:master Jul 16, 2020
@manusa manusa deleted the fix/configurations branch July 16, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly name and document (Maven/System) configuration properties
3 participants