Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Vert.x generator and enricher applicable when io.vertx dependencies present #329

Merged
merged 1 commit into from Jul 29, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jul 29, 2020

Description

fix: Vert.x generator and enricher to be applicable when io.vertx dependencies present

Previously projects containing a <dependency><groupId>io.vertx</groupId><!-- .... --></dependency> were not being picked up by Vert.x generator and enricher since the behavior of JKubeProjectUtil.hasDependency(getProject(), Constants.VERTX_GROUPID, null) was not the one expected before Maven decoupling happened.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #329 into master will increase coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #329      +/-   ##
============================================
+ Coverage     33.74%   33.76%   +0.02%     
- Complexity     2169     2174       +5     
============================================
  Files           364      364              
  Lines         18564    18567       +3     
  Branches       2741     2741              
============================================
+ Hits           6265     6270       +5     
+ Misses        11550    11547       -3     
- Partials        749      750       +1     
Impacted Files Coverage Δ Complexity Δ
...clipse/jkube/kit/enricher/api/EnricherContext.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...jkube/vertx/enricher/VertxHealthCheckEnricher.java 89.57% <0.00%> (ø) 57.00 <0.00> (ø)
...clipse/jkube/kit/common/util/JKubeProjectUtil.java 14.00% <100.00%> (+5.48%) 5.00 <2.00> (+2.00)
.../eclipse/jkube/vertx/generator/VertxGenerator.java 52.50% <100.00%> (+5.00%) 11.00 <0.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24963d...015b624. Read the comment docs.

…ncies present

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa manusa merged commit 2a29784 into eclipse-jkube:master Jul 29, 2020
@manusa manusa deleted the fix/vertx-generator-applicable branch July 29, 2020 15:07
@manusa manusa added this to Done in Sprint #187 Jul 30, 2020
@manusa manusa self-assigned this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint #187
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants