Add Sample Quickstarts to project #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
Coverage 24.46% 24.46%
Complexity 1334 1334
=========================================
Files 326 326
Lines 17603 17603
Branches 2691 2691
=========================================
Hits 4307 4307
Misses 12805 12805
Partials 491 491Continue to review full report at Codecov.
|
manusa
reviewed
Dec 20, 2019
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <artifactId>jshift-maven-sample-spring-boot</artifactId> | ||
| <groupId>io.jshift</groupId> |
There was a problem hiding this comment.
Replace by valid groupID (also artifcatId is not OK)
manusa
reviewed
Dec 20, 2019
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>io.jshift</groupId> |
There was a problem hiding this comment.
Same. Check all files for "fabric8" or "jshift"
manusa
reviewed
Dec 20, 2019
| * Contributors: | ||
| * Red Hat, Inc. - initial API and implementation | ||
| */ | ||
| package io.fabric8.mven.sample.thorntail.rest; |
There was a problem hiding this comment.
Do we want to keep fabric8 package names?
manusa
reviewed
Dec 20, 2019
| <html> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <title>fabric8:Maven Plugin</title> |
There was a problem hiding this comment.
Maybe use more appropriate values e.g. "Eclipse JKube"
manusa
reviewed
Dec 20, 2019
| </head> | ||
|
|
||
| <body> | ||
| <h2>fabric8 maven plugin rocks!!</h2> |
rohanKanojia
force-pushed
the
pr/add-samples
branch
from
e8a82b6
to
1cf6dae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not directly linked to project so not sure whether we should file CQs for these or not.