Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc to align with property jkube.openshift.imageChangeTriggers #344

Merged
merged 1 commit into from Aug 5, 2020
Merged

Fix doc to align with property jkube.openshift.imageChangeTriggers #344

merged 1 commit into from Aug 5, 2020

Conversation

sejacobsen
Copy link
Contributor

@sejacobsen sejacobsen commented Aug 5, 2020

Signed-off-by: Søren Jacobsen sej@aety.io

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

Signed-off-by: Søren Jacobsen <sej@aety.io>
@sejacobsen sejacobsen marked this pull request as ready for review August 5, 2020 14:08
@sejacobsen
Copy link
Contributor Author

Documentation fix only. No unit test or Kubernets/Openshift test

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #344 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #344   +/-   ##
=========================================
  Coverage     33.76%   33.76%           
  Complexity     2174     2174           
=========================================
  Files           364      364           
  Lines         18567    18567           
  Branches       2740     2740           
=========================================
  Hits           6270     6270           
  Misses        11548    11548           
  Partials        749      749           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 256ec3e...f146358. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for contributing!

@manusa manusa merged commit 0d56e87 into eclipse-jkube:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants