Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Quarkus supports S2I builds both for JVM and native mode #362

Merged
merged 1 commit into from Aug 21, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Aug 21, 2020

Description

fix: Quarkus supports S2I builds both for JVM and native mode

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #362 into master will increase coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #362      +/-   ##
============================================
+ Coverage     34.93%   34.94%   +0.01%     
- Complexity     2270     2272       +2     
============================================
  Files           378      378              
  Lines         18726    18731       +5     
  Branches       2745     2745              
============================================
+ Hits           6542     6546       +4     
- Misses        11402    11403       +1     
  Partials        782      782              
Impacted Files Coverage Δ Complexity Δ
...ipse/jkube/quarkus/generator/QuarkusGenerator.java 55.84% <81.81%> (+1.67%) 8.00 <3.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a7bf8...9a1cc0d. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@rohanKanojia rohanKanojia merged commit 5548934 into eclipse-jkube:master Aug 21, 2020
@manusa manusa deleted the fix/quarkus-s2i branch August 24, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants