Add Maven Enforcer Plugin #29 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=========================================
Coverage 24.46% 24.46%
Complexity 1334 1334
=========================================
Files 326 326
Lines 17603 17603
Branches 2691 2691
=========================================
Hits 4307 4307
Misses 12805 12805
Partials 491 491
Continue to review full report at Codecov.
|
manusa
force-pushed
the
fix/dependency-convergence-v2
branch
2 times, most recently
from
6f1ff11
to
ec59236
Compare
rohanKanojia
reviewed
Jan 7, 2020
README.md
Outdated
| @@ -21,11 +21,11 @@ Actually it contains the following abstractions which has been extracted from bo | |||
| * **Jkube-kit**, which consists of the following: | |||
|
|
|||
| * **Generator** framework for automatically generating Docker images by examining project information.<br /> | |||
| [](https://search.maven.org/search?q=g:%22org.eclipse.jkube%22%20AND%20a:%22jkube-maven-generator-api%22) [](http://www.javadoc.io/doc/org.eclipse.jkube/jkube-maven-generator-api) | |||
| [](https://search.maven.org/search?q=g:%22org.eclipse.jkube%22%20AND%20a:%22jkube-kit-generator-api%22) [](http://www.javadoc.io/doc/org.eclipse.jkube/jkube-kit-generator-api) | |||
There was a problem hiding this comment.
Shall we update badges after we cut release? WDYT?
There was a problem hiding this comment.
OK, I'll add an additional commit on top of this one that can be easily reverted after next release.
rohanKanojia
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Looks good, Thanks 👍
I've added a CHANGELOG file https://github.com/eclipse/jkube/blob/master/CHANGELOG.md . Could you please add a line regarding this change to that file?
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
fix/dependency-convergence-v2
branch
from
b3b05b4
to
52fdb78
Compare
rohanKanojia
approved these changes
Jan 7, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
dependencyConvergencerule to maven-enforcer-plugin: All dependency versions must converge in order to prevent duplicate dependencies and non-deterministic behaviors caused by random class load order.All version references are located (alphabetically ordered) in the parent's pom properties (root for inter-project dependencies)
Treeshaked all poms to remove redundant dependencies and attributes.
Added 4 specific dependencies to avoid collisions. CQs must be opened for get legal approval:
Renamed several artifacts to have a consistent naming pattern across the project.
Closes #29