Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close input streams + other fixes #41

Merged
merged 3 commits into from
Jan 20, 2020
Merged

Close input streams + other fixes #41

merged 3 commits into from
Jan 20, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jan 7, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented Jan 7, 2020 •
edited
Loading

Codecov Report

Merging #41 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
+ Coverage     24.46%   24.47%   +<.01%     
  Complexity     1334     1334              
============================================
  Files           326      326              
  Lines         17603    17601       -2     
  Branches       2691     2691              
============================================
  Hits           4307     4307              
+ Misses        12805    12803       -2     
  Partials        491      491
Impacted Files Coverage Δ Complexity Δ
...kube/springboot/generator/SpringBootGenerator.java 17.85% <0%> (+0.12%) 8 <0> (ø) ⬇️
.../kit/build/service/docker/wait/TcpPortChecker.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e76b6e...c90e4b0. Read the comment docs.

@manusa
fix: watcher-default typo
a66e4da 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa
fix: Close input streams
38a2c24 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa
fix: Missing component declaration in Plexus container
c90e4b0 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa changed the title wip: Close input streams !!DRAFT Close input streams + other fixes Jan 7, 2020
@manusa manusa marked this pull request as ready for review January 7, 2020 12:26
rohanKanojia
rohanKanojia approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks!

@rohanKanojia rohanKanojia merged commit e1f2bfb into eclipse-jkube:master Jan 20, 2020
@manusa manusa deleted the fix/sonar-reported-bugs branch January 20, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manusa @rohanKanojia