Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Valid content type for REST docker API requests with body #442

Merged
merged 1 commit into from Oct 21, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Oct 20, 2020

Description

fix: Valid content type for REST docker API requests with body

Relates to: #66 (#66 (comment))

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #442 into master will increase coverage by 0.17%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #442      +/-   ##
============================================
+ Coverage     36.93%   37.10%   +0.17%     
- Complexity     2415     2432      +17     
============================================
  Files           388      388              
  Lines         19097    19100       +3     
  Branches       2788     2790       +2     
============================================
+ Hits           7053     7087      +34     
+ Misses        11204    11171      -33     
- Partials        840      842       +2     
Impacted Files Coverage Δ Complexity Δ
...ice/docker/access/hc/ApacheHttpClientDelegate.java 50.72% <87.50%> (+49.20%) 17.00 <2.00> (+17.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fdbf5...28f7da9. Read the comment docs.

@manusa manusa added this to the 1.0.2 milestone Oct 21, 2020
@manusa manusa self-assigned this Oct 21, 2020
@manusa manusa added this to Review in Sprint #191 Oct 21, 2020
@manusa manusa added the bug Something isn't working label Oct 21, 2020
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

92.3% 92.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa manusa merged commit 20754b1 into eclipse-jkube:master Oct 21, 2020
Sprint #191 automation moved this from Review to Done Oct 21, 2020
@manusa manusa deleted the fix/docker-content-type branch October 21, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Sprint #191
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants