Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed misleading watch-postGoal warning + fixed rolling update in DockerImageWatcher #447

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Oct 22, 2020

Description

fix: Removed misleading watch-postGoal warning + fixed rolling update in DockerImageWatcher

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@manusa manusa self-assigned this Oct 22, 2020
@manusa manusa added the bug Something isn't working label Oct 22, 2020
@manusa manusa added this to Review in Sprint #191 Oct 22, 2020
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #447 into master will increase coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #447   +/-   ##
=========================================
  Coverage     37.37%   37.38%           
+ Complexity     2456     2455    -1     
=========================================
  Files           389      389           
  Lines         19108    19103    -5     
  Branches       2794     2788    -6     
=========================================
- Hits           7142     7141    -1     
+ Misses        11117    11114    -3     
+ Partials        849      848    -1     
Impacted Files Coverage Δ Complexity Δ
...pse/jkube/watcher/standard/DockerImageWatcher.java 29.50% <0.00%> (+0.23%) 9.00 <0.00> (ø)
...pse/jkube/maven/plugin/mojo/develop/WatchMojo.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/jkube/kit/build/service/docker/WatchService.java 24.15% <100.00%> (-0.57%) 7.00 <1.00> (-1.00)
...e/kit/build/service/docker/watch/WatchContext.java 28.00% <100.00%> (ø) 6.00 <1.00> (ø)
...a/org/eclipse/jkube/kit/common/util/MavenUtil.java 36.66% <100.00%> (+0.55%) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1ef1d...6f926aa. Read the comment docs.

@manusa manusa force-pushed the fix/watch-rolling-update branch 2 times, most recently from ecaaafd to 48f1726 Compare October 22, 2020 15:42
@manusa manusa added this to the 1.0.2 milestone Oct 27, 2020
… in DockerImageWatcher

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

11.1% 11.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa manusa added this to Review in Sprint #192 Oct 28, 2020
@manusa manusa merged commit 3005d57 into eclipse-jkube:master Oct 30, 2020
@manusa manusa deleted the fix/watch-rolling-update branch October 30, 2020 10:39
@manusa manusa moved this from Review to Done in Sprint #192 Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Sprint #191
  
Review
Sprint #192
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants